Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stoud check for main tests #10

Merged
merged 2 commits into from
Feb 6, 2024
Merged

Conversation

Monnte
Copy link
Member

@Monnte Monnte commented Jan 24, 2024

OAMG-10421

@codecov-commenter
Copy link

codecov-commenter commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (405820b) 100.00% compared to head (b65a4f8) 100.00%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #10   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines          164       165    +1     
=========================================
+ Hits           164       165    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@andywaltlova andywaltlova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start! I would expect to test main for all possible raise ProcessError in script - failed leapp install/other pkg.

I would probably also check if alert is true or false based on what is expected for each output message.

tests/test_main.py Outdated Show resolved Hide resolved
@Monnte Monnte force-pushed the feature/tests-check-stdout branch from b65a4f8 to d95bcd5 Compare February 6, 2024 14:03
@andywaltlova andywaltlova merged commit 4611548 into main Feb 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants