-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use symlink to common #2505
Use symlink to common #2505
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fetched the branch, generated ovirt-site and verified that include statements that reference the symlinked /common/ directory work as expected.
I did not verify that all links to the /common/ directory were changes to reference the symlink.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm all in for upstream first of course \o/.
There's a regression when testing the site with bundle exec jekyll s
:
** ERROR: directory is already being watched! **
Directory: /home/duck/Projects/oVirt/ovirt-site/source/documentation/data_warehouse_guide/common
is already being watched through: /home/duck/Projects/oVirt/ovirt-site/source/documentation/common
and others, so some patterns are not right.
RHV documentation uses a system that requires common directory to be within each docuemtation guide. Using symlinks here to help moving the documentation to upstream first. It has a downside: live reload raises errors like: Directory: ovirt-site/source/documentation/migrating_from_a_standalone_manager_to_a_self-hosted_engine/common is already being watched through: ovirt-site/source/documentation/common MORE INFO: https://github.com/guard/listen/blob/master/README.md ** ERROR: directory is already being watched! ** Signed-off-by: Sandro Bonazzola <[email protected]>
Signed-off-by: Sandro Bonazzola <[email protected]>
870e238
to
a59b5bc
Compare
I addressed comments about the config file, added a note about the symlink generated error. |
@sandrobonazzola I looked into jekyll-watch and it takes the Since there's no way to get the right behavior I looked in the suggested monkeypatch: I believe it is doing the right thing, skipping the warning message but failing in a way that will only skip listening to the symlink target. I have then integrated it in a new patch that I intend to push right after this message. |
Changes proposed in this pull request:
I confirm that this pull request was submitted according to the contribution guidelines: @sandrobonazzola
This pull request needs review by: @stoobie @duck-rh