Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add service success setting in ROS2SpawnerComponent::GetAvailableSpawnableNames #828

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

knicked
Copy link
Contributor

@knicked knicked commented Feb 18, 2025

What does this PR do?

The /get_available_spawnable_names service in ROS2 Spawner always returned success=False in response, while there were no issues in calling the service. This PR adds setting the success field to true in the appropriate method.

How was this PR tested?

A scene with ROS2 Spawner was loaded and played in the editor and the service was called:

$ ros2 service call /get_available_spawnable_names gazebo_msgs/srv/GetWorldProperties
requester: making request: gazebo_msgs.srv.GetWorldProperties_Request()

response:
gazebo_msgs.srv.GetWorldProperties_Response(sim_time=0.0, model_names=['tomato', 'green_cube', 'apple', 'blue_cube', 'corn', 'toy_box', 'carrot', 'red_cube', 'yellow_cube'], rendering_enabled=False, success=True, status_message='')

@knicked knicked requested review from a team as code owners February 18, 2025 12:45
@byrcolin byrcolin added the sig/simulation Categorizes an issue or PR as relevant to SIG Simulation label Feb 18, 2025
@jhanca-robotecai jhanca-robotecai merged commit d79be36 into o3de:development Feb 19, 2025
2 checks passed
@jhanca-robotecai jhanca-robotecai deleted the kd/spawner_fix branch February 19, 2025 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/simulation Categorizes an issue or PR as relevant to SIG Simulation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants