Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add query_respnse_hit_ids and query_response_id to schema version 1.3.0 #34

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

wrigleyDan
Copy link

closes #33

@wrigleyDan
Copy link
Author

Looks like I cannot tag this branch with the 1.3 milestone (https://github.com/o19s/ubi/milestone/3). Can you do that @epugh ?

@epugh epugh added this to the 1.3 milestone Jan 22, 2025
@epugh
Copy link
Member

epugh commented Jan 22, 2025

Looks like I cannot tag this branch with the 1.3 milestone (https://github.com/o19s/ubi/milestone/3). Can you do that @epugh ?

done. can we jump on zoom an dcompare UI's? curious what permission you are missing!

@epugh
Copy link
Member

epugh commented Jan 22, 2025

you know, we should add to the docs how you split the next rev into two PR's, so you can diff the chnage... This one gets lots in all the boilerplate of the initial copy of 1.2 --> 1.3.

@wrigleyDan
Copy link
Author

Looks like I cannot tag this branch with the 1.3 milestone (https://github.com/o19s/ubi/milestone/3). Can you do that @epugh ?

done. can we jump on zoom an dcompare UI's? curious what permission you are missing!

Sure, let's have a look. I wasn't allowed to create a new branch as well, so might be that I'm missing "all" permissions that don't automatically come with a public repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "query_response_hit_ids" to query.request schema
2 participants