Generalize over field variable type #861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dannywillems
reviewed
Jan 8, 2025
| @@ -298,9 +298,9 @@ end | |||
| module type Field_var_intf = sig | |||
| type field | |||
|
|
|||
| (** The type that stores booleans as R1CS variables. *) | |||
There was a problem hiding this comment.
Wait. You're reading the documentation now? 😮
dannywillems
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR relaxes the constraint that
field_var = field Cvar.t, allowing the backend to select an appropriate variable kind according to its needs. Importantly, this also lets us use a type defined in the rust FFI, allowing us to plug into a shared backend with o1rs.