Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use E1/E2::ScalarField instead of Fp/Fq #2981

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

dannywillems
Copy link
Member

Using Fq/Fp required to add more type constraints when working on #2938. Therefore, I suggest to always use E1/E2::ScalarField.

Base automatically changed from arrabbiata/simplify-type-constraints to master January 30, 2025 15:23
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

Attention: Patch coverage is 91.30435% with 2 lines in your changes missing coverage. Please review.

Project coverage is 76.84%. Comparing base (8bb7b7a) to head (a88fc63).
Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
arrabbiata/src/witness.rs 91.30% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2981      +/-   ##
==========================================
- Coverage   76.85%   76.84%   -0.02%     
==========================================
  Files         261      261              
  Lines       61370    61370              
==========================================
- Hits        47168    47161       -7     
- Misses      14202    14209       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dannywillems dannywillems merged commit 5df3d41 into master Jan 30, 2025
12 of 13 checks passed
@dannywillems dannywillems deleted the arrabbiata/use-curve-instead-of-field branch January 30, 2025 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants