Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

factor out utils module #2965

Merged
merged 3 commits into from
Jan 24, 2025
Merged

factor out utils module #2965

merged 3 commits into from
Jan 24, 2025

Conversation

martyall
Copy link
Contributor

@martyall martyall commented Jan 23, 2025

Factor out some utils to a separate module, came up in #2965 when trying to share some code

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.84%. Comparing base (fe10025) to head (71fc4e8).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2965      +/-   ##
==========================================
- Coverage   76.85%   76.84%   -0.02%     
==========================================
  Files         258      259       +1     
  Lines       61202    61257      +55     
==========================================
+ Hits        47036    47071      +35     
- Misses      14166    14186      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martyall martyall marked this pull request as ready for review January 23, 2025 22:50
Copy link
Contributor

@Fizzixnerd Fizzixnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish decode_into wasn't required, but I guess rust move semantics aren't as advanced as I'd like!

@martyall martyall merged commit 5ae78ca into master Jan 24, 2025
13 checks passed
@martyall martyall deleted the martin/saffron-utils-mod branch January 24, 2025 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants