Saffron e2e tests in CI #2957
Merged
Saffron e2e tests in CI #2957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martyall
changed the title
martyall
commented
Jan 21, 2025
| @@ -1,3 +1 @@ | |||
| proptest-regressions | |||
| fixtures/lorem.bin | |||
There was a problem hiding this comment.
I just modified the test script to delete these files if the test passes.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2957 +/- ##
==========================================
- Coverage 76.58% 76.53% -0.05%
==========================================
Files 255 258 +3
Lines 61034 61160 +126
==========================================
+ Hits 46741 46807 +66
- Misses 14293 14353 +60 ☔ View full report in Codecov by Sentry. |
|
|
||
| - name: Run the saffron e2e encoding tests | ||
| run: | | ||
| ./saffron/test-encoding.sh saffron/fixtures/lorem.txt |
There was a problem hiding this comment.
You're building in release mode above, but the script doesn't use the release flag. Therefore, the command above is useless.
dannywillems
requested changes
Jan 22, 2025
dannywillems
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add CI for saffron e2e test (bash scripts using the CLI)