Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

encoding/decoding for saffron data #2955

Merged
merged 3 commits into from
Jan 21, 2025
Merged

encoding/decoding for saffron data #2955

merged 3 commits into from
Jan 21, 2025

Conversation

martyall
Copy link
Contributor

Scaffolding for saffron cli

  • Set up the crate
  • Enable CLI
  • Add functions to encode/decode data from bytes to field elements
  • Add tests (property based tests and shell script to test cli)

@martyall martyall marked this pull request as ready for review January 16, 2025 16:03
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 64.95726% with 41 lines in your changes missing coverage. Please review.

Project coverage is 76.51%. Comparing base (3ebeaf4) to head (0ea239e).
Report is 15 commits behind head on master.

Files with missing lines Patch % Lines
saffron/src/main.rs 0.00% 27 Missing ⚠️
saffron/src/cli.rs 0.00% 7 Missing ⚠️
saffron/src/serialization.rs 91.56% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2955      +/-   ##
==========================================
- Coverage   76.61%   76.51%   -0.11%     
==========================================
  Files         255      258       +3     
  Lines       61014    61188     +174     
==========================================
+ Hits        46747    46818      +71     
- Misses      14267    14370     +103     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Fizzixnerd Fizzixnerd force-pushed the martin/saffron-skeleton branch from 528e18f to 0ea239e Compare January 16, 2025 21:02
@martyall martyall requested a review from dannywillems January 21, 2025 16:27
@martyall martyall merged commit d7b7782 into master Jan 21, 2025
22 of 23 checks passed
@martyall martyall deleted the martin/saffron-skeleton branch January 21, 2025 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants