added srs_cache cli arg #2940
Open
added srs_cache cli arg #2940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| srs | ||
| let srs: SRS<Vesta> = match &args.srs_cache { | ||
| Some(cache) => { | ||
| debug!("Loading SRS from cache {}", cache); |
There was a problem hiding this comment.
I would check that the SRS is of the expected size (DOMAIN_SIZE).
| @@ -1,6 +1,6 @@ | |||
| use ark_ff::UniformRand; | |||
| use clap::Parser; | |||
| use kimchi::circuits::domains::EvaluationDomains; | |||
| use kimchi::{circuits::domains::EvaluationDomains, precomputed_srs::TestSRS}; | |||
There was a problem hiding this comment.
Out of the scope of this PR: it would be nice to move this structure TestSRS in poly_commitment in ipa.rs, next to SRS. We should also have a unified structure for TestSRS and SRS. It is mostly the encoding the difference. I guess we can have a parameter or something to serde.
| @@ -105,6 +105,8 @@ impl From<MipsVmConfigurationArgs> for VmConfiguration { | |||
| pub struct RunArgs { | |||
| #[arg(long = "preimage-db-dir", value_name = "PREIMAGE_DB_DIR")] | |||
| pub preimage_db_dir: Option<String>, | |||
| #[arg(long = "srs-cache", value_name = "SRS_CACHE")] | |||
There was a problem hiding this comment.
Maybe simply srs or srs_filename or srs_path?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been floating around for a while but is extremely useful to save time on loading the SRS