Add first sketch of the environment for the serializer circuit #1860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volhovm
approved these changes
Feb 28, 2024
| /// Environment for the serializer interpreter | ||
| /// It is parametrized by the number of field elements to be serialized and the | ||
| /// field | ||
| pub struct Env<const N: usize, Fp> { |
There was a problem hiding this comment.
This is building witness, right? We have three kind of environments IIRC: witness, constraint, and column (anything else?). I won't block on naming conventions, but WitnessBuilder perhaps would be a more descriptive name?
| /// field | ||
| pub struct Env<const N: usize, Fp> { | ||
| pub step: usize, | ||
| pub kimchi_limbs: [[Fp; 3]; N], |
There was a problem hiding this comment.
I'm also thinking if it's a builder-like struct, then probably the fields should be not arrays but vectors, and we intend to append to them? So far this Env seems to express just one row of our computation -- is that intentional or we want to have multiple rows?..
There was a problem hiding this comment.
One row of computation.
Base automatically changed from
dw/add-trait-interpreter-serialization
to
master
February 28, 2024 14:12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.