once more for great good

o1-labs · Jan 14, 2025 · fa0e981 · fa0e981
1 parent cb2fe2b
commit fa0e981
Show file tree

Hide file tree

Showing 2 changed files with 34 additions and 34 deletions.
diff --git a/o1vm/src/interpreters/mips/witness.rs b/o1vm/src/interpreters/mips/witness.rs
@@ -622,12 +622,10 @@ impl<Fp: Field, PreImageOracle: PreImageOracleT> InterpreterEnv for Env<Fp, PreI
                     preimage_key[4 * i + j] = bytes[j]
                 }
             }
-            let preimage: Vec<u8> = panic!(
+            panic!(
                 "Attempted to get preimage key {}",
                 hex::encode(preimage_key)
             );
-            self.preimage = Some(preimage.clone());
-            self.preimage_key = Some(preimage_key);
         }
 
         const LENGTH_SIZE: usize = 8;

diff --git a/o1vm/src/preimage_oracle.rs b/o1vm/src/preimage_oracle.rs
@@ -3,7 +3,7 @@ use crate::cannon::{
     PREIMAGE_CLIENT_READ_FD, PREIMAGE_CLIENT_WRITE_FD,
 };
 use command_fds::{CommandFdExt, FdMapping};
-use log::debug;
+//use log::debug;
 use os_pipe::{PipeReader, PipeWriter};
 use std::{
     io::{Read, Write},
@@ -20,7 +20,9 @@ pub struct PreImageOracle {
 }
 
 pub trait PreImageOracleT {
-    fn get_preimage(&mut self, key: [u8; 32]) -> Preimage;
+    fn get_preimage(&mut self, key: [u8; 32]) -> Preimage {
+        panic!("This function is never being used {}", hex::encode(key));
+    }
 
     fn hint(&mut self, hint: Hint);
 }
@@ -178,35 +180,35 @@ impl PreImageOracleT for PreImageOracle {
     //   b. the preimage data, with a size of <length> bits
     #[allow(unreachable_code)]
     fn get_preimage(&mut self, key: [u8; 32]) -> Preimage {
-        panic!("Attempted to get preimage for key {}", hex::encode(&key));
-        let RW(ReadWrite { reader, writer }) = &mut self.oracle_client;
-
-        let r = writer.write_all(&key);
-        assert!(r.is_ok());
-        let r = writer.flush();
-        assert!(r.is_ok());
-
-        debug!("Reading response");
-        let mut buf = [0_u8; 8];
-        let resp = reader.read_exact(&mut buf);
-        assert!(resp.is_ok());
-
-        debug!("Extracting contents");
-        let length = u64::from_be_bytes(buf);
-        let mut preimage = vec![0_u8; length as usize];
-        let resp = reader.read_exact(&mut preimage);
-
-        assert!(resp.is_ok());
-
-        debug!(
-            "Got preimage of length {}\n {}",
-            preimage.len(),
-            hex::encode(&preimage)
-        );
-        // We should have read exactly <length> bytes
-        assert_eq!(preimage.len(), length as usize);
-
-        Preimage::create(preimage)
+        panic!("Attempted to get preimage for key {}", hex::encode(key));
+        //let RW(ReadWrite { reader, writer }) = &mut self.oracle_client;
+
+        //let r = writer.write_all(&key);
+        //assert!(r.is_ok());
+        //let r = writer.flush();
+        //assert!(r.is_ok());
+
+        //debug!("Reading response");
+        //let mut buf = [0_u8; 8];
+        //let resp = reader.read_exact(&mut buf);
+        //assert!(resp.is_ok());
+
+        //debug!("Extracting contents");
+        //let length = u64::from_be_bytes(buf);
+        //let mut preimage = vec![0_u8; length as usize];
+        //let resp = reader.read_exact(&mut preimage);
+
+        //assert!(resp.is_ok());
+
+        //debug!(
+        //    "Got preimage of length {}\n {}",
+        //    preimage.len(),
+        //    hex::encode(&preimage)
+        //);
+        //// We should have read exactly <length> bytes
+        //assert_eq!(preimage.len(), length as usize);
+
+        //Preimage::create(preimage)
     }
 
     // The hint protocol goes as follows: