danny pr comments

o1-labs · Jan 10, 2025 · 6e3ef5d · 6e3ef5d
1 parent 2f46130
commit 6e3ef5d
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/o1vm/src/cli/cannon.rs b/o1vm/src/cli/cannon.rs
@@ -105,7 +105,7 @@ impl From<MipsVmConfigurationArgs> for VmConfiguration {
 pub struct RunArgs {
     #[arg(long = "preimage-db-dir", value_name = "PREIMAGE_DB_DIR")]
     pub preimage_db_dir: Option<String>,
-    #[arg(long = "srs-cache", value_name = "SRS_CACHE")]
+    #[arg(long = "srs-filepath", value_name = "SRS_CACHE")]
     pub srs_cache: Option<String>,
     // it's important that vm_cfg is last in order to properly parse the host field
     #[command(flatten)]

diff --git a/o1vm/src/pickles/main.rs b/o1vm/src/pickles/main.rs
@@ -69,6 +69,13 @@ pub fn cannon_main(args: cli::cannon::RunArgs) {
                     rmp_serde::from_read(&file).unwrap()
                 }
             };
+            if srs.size() != DOMAIN_SIZE {
+                panic!(
+                    "SRS size mismatch. Expected {}, got {}",
+                    DOMAIN_SIZE,
+                    srs.size()
+                );
+            }
             debug!("SRS loaded successfully from cache");
             srs
         }