Merge pull request #2791 from o1-labs/dw/riscv32-impl-mul-lo-signed

o1vm/riscv32: implement mul_lo_signed

o1vm/src/interpreters/riscv32im/constraints.rs

@@ -336,6 +336,15 @@ impl<Fp: Field> InterpreterEnv for Env<Fp> {
         self.variable(position)
     }
 
+    unsafe fn mul_lo_signed(
+        &mut self,
+        _x: &Self::Variable,
+        _y: &Self::Variable,
+        position: Self::Position,
+    ) -> Self::Variable {
+        self.variable(position)
+    }
+
     unsafe fn mul_hi_lo(
         &mut self,
         _x: &Self::Variable,

o1vm/src/interpreters/riscv32im/interpreter.rs

@@ -1215,6 +1215,20 @@ pub trait InterpreterEnv {
         position: Self::Position,
     ) -> Self::Variable;
 
+    /// Returns `(x * y) & ((1 << 32) - 1))`, storing the results in `position`
+    ///
+    /// # Safety
+    ///
+    /// There are no constraints on the returned values; callers must manually add constraints to
+    /// ensure that the pair of returned values correspond to the given values `x` and `y`, and
+    /// that they fall within the desired range.
+    unsafe fn mul_lo_signed(
+        &mut self,
+        x: &Self::Variable,
+        y: &Self::Variable,
+        position: Self::Position,
+    ) -> Self::Variable;
+
     /// Returns `((x * y) >> 32, (x * y) & ((1 << 32) - 1))`, storing the results in `position_hi`
     /// and `position_lo` respectively.
     ///

o1vm/src/interpreters/riscv32im/witness.rs

@@ -456,6 +456,21 @@ impl<Fp: Field> InterpreterEnv for Env<Fp> {
         res
     }
 
+    unsafe fn mul_lo_signed(
+        &mut self,
+        x: &Self::Variable,
+        y: &Self::Variable,
+        position: Self::Position,
+    ) -> Self::Variable {
+        let x: i32 = (*x).try_into().unwrap();
+        let y: i32 = (*y).try_into().unwrap();
+        let res = ((x as i64) * (y as i64)) as u64;
+        let res = (res & ((1 << 32) - 1)) as u32;
+        let res = res as u64;
+        self.write_column(position, res);
+        res
+    }
+
     unsafe fn mul_hi_lo_signed(
         &mut self,
         x: &Self::Variable,