fix: fix ActionRowWrapper#editWhere() editing unmatched entries

nyx-discord · Jan 19, 2024 · dec24e5 · dec24e5
1 parent 5f7abad
commit dec24e5
Showing 1 changed file with 7 additions and 10 deletions.
diff --git a/packages/framework/src/discord/ActionRowWrapper.ts b/packages/framework/src/discord/ActionRowWrapper.ts
@@ -74,17 +74,14 @@ export class ActionRowWrapper<ComponentData extends ActionRowComponentData> {
     callback: ComponentEditCallback<ComponentData>,
     many = true,
   ): this {
-    let appliableComponents = this.components.filter((component) =>
-      where(component),
-    );
-    if (!many) {
-      appliableComponents = appliableComponents.length
-        ? [appliableComponents[0]]
-        : [];
-    }
-    for (const [index, component] of appliableComponents.entries()) {
-      this.components[index] = callback(component);
+    for (const component of this.components) {
+      if (where(component)) {
+        const index = this.components.indexOf(component);
+        this.components[index] = callback(component);
+        if (!many) break;
+      }
     }
+
     return this;
   }