Improve error handling for attachments #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or-for-large-file-size
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #244 +/- ##
============================================
+ Coverage 80.13% 80.22% +0.09%
Complexity 287 287
============================================
Files 31 31
Lines 861 870 +9
Branches 87 88 +1
============================================
+ Hits 690 698 +8
Misses 121 121
- Partials 50 51 +1 ☔ View full report in Codecov by Sentry. |
mrashed-dev
deleted the
CUST-2685-v-3-java-sdk-returning-unknown-error-for-large-file-size
branch
Merged
mrashed-dev
added a commit
that referenced
this pull request
Sep 25, 2024
# Changelog ### Added * Added new error class `NylasSdkRemoteClosedError` for when the remote connection is closed (#244) * Added support for new filter fields for listing events (#245) * Added response headers to Nylas API error objects (#246, #221) # License <!-- Your PR comment must contain the following line for us to merge the PR. --> I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a new error in the case that a user uploads a file that is too large, causing the remote connection to be closed on the API side.
License
I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.