Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to generic StartProgress widget #456

Merged
merged 3 commits into from
Sep 25, 2024
Merged

Switch to generic StartProgress widget #456

merged 3 commits into from
Sep 25, 2024

Conversation

ericnewcomer
Copy link
Member

No description provided.

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

Attention: Patch coverage is 37.91469% with 131 lines in your changes missing coverage. Please review.

Project coverage is 79.43%. Comparing base (1dc3078) to head (a848a5d).

Files with missing lines Patch % Lines
src/progress/StartProgress.ts 15.58% 130 Missing ⚠️
src/dialog/Modax.ts 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #456      +/-   ##
==========================================
- Coverage   79.65%   79.43%   -0.22%     
==========================================
  Files          88       88              
  Lines       22885    22997     +112     
  Branches      754      755       +1     
==========================================
+ Hits        18228    18267      +39     
- Misses       4657     4730      +73     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ericnewcomer ericnewcomer merged commit 78b078d into main Sep 25, 2024
2 of 4 checks passed
@ericnewcomer ericnewcomer deleted the generic-start branch September 25, 2024 18:29
@github-actions github-actions bot locked and limited conversation to collaborators Sep 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant