Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include number of records on notifications for some export types #424

Merged
merged 1 commit into from
May 7, 2024

Conversation

rowanseymour
Copy link
Member

No description provided.

Copy link

codecov bot commented May 7, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 79.21%. Comparing base (7264111) to head (9e57eb4).

Files Patch % Lines
src/list/NotificationList.ts 25.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #424   +/-   ##
=======================================
  Coverage   79.21%   79.21%           
=======================================
  Files          80       80           
  Lines       22020    22021    +1     
  Branches      750      750           
=======================================
+ Hits        17444    17445    +1     
  Misses       4565     4565           
  Partials       11       11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ericnewcomer ericnewcomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exported 1 contacts.

@rowanseymour
Copy link
Member Author

@ericnewcomer I was just trying to keep it consistent with Imported 1 contacts. !

@rowanseymour rowanseymour merged commit 62a2cf3 into main May 7, 2024
3 of 4 checks passed
@rowanseymour rowanseymour deleted the export_notification_num_records branch May 7, 2024 16:17
@github-actions github-actions bot locked and limited conversation to collaborators May 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants