Support flow export notification #423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #423 +/- ##
==========================================
- Coverage 79.22% 79.21% -0.01%
==========================================
Files 80 80
Lines 22016 22020 +4
Branches 750 750
==========================================
+ Hits 17443 17444 +1
- Misses 4562 4565 +3
Partials 11 11 ☔ View full report in Codecov by Sentry. |
norkans7
force-pushed
the
support-flow-export-notifications
branch
2 times, most recently
from
68b7049 to
dd361d6
Compare
rowanseymour
reviewed
May 7, 2024
src/list/NotificationList.ts
Outdated
| @@ -100,6 +100,9 @@ export class NotificationList extends TembaList { | |||
| } else if (notification.export.type === 'ticket') { | |||
| icon = Icon.tickets_export; | |||
| body = 'Exported tickets'; | |||
| } else if (notification.export.type === 'flows') { | |||
There was a problem hiding this comment.
how about definition since they're not just flows?
contact, message, results and definition
There was a problem hiding this comment.
And the body can be Exported definitions ? @rowanseymour
norkans7
force-pushed
the
support-flow-export-notifications
branch
from
dd361d6 to
cd69bec
Compare
rowanseymour
approved these changes
May 7, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.