IsEmergency functions for short numbers #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
S4more
changed the title
S4more
changed the title
shortnumber_info.go
Outdated
| @@ -1,6 +1,8 @@ | |||
| package phonenumbers | |||
|
|
|||
| import ( | |||
| "slices" | |||
There was a problem hiding this comment.
use golang.org/x/exp/slices
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #191 +/- ##
==========================================
+ Coverage 46.81% 47.61% +0.80%
==========================================
Files 11 11
Lines 3798 3818 +20
==========================================
+ Hits 1778 1818 +40
+ Misses 1869 1851 -18
+ Partials 151 149 -2 ☔ View full report in Codecov by Sentry. |
|
@S4more thanks! Released as 1.5.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
ConnectsToEmergencyNumberandIsEmergencyNumberbased on Java implementation.There was also a typo XML builder that would prevent the
emergencyXML tag from being parsed.The metadata for shortnumbers needs to be updated. Not sure if I should also update the other as well
partially solves #184