feat!(rocks-bin/build): project lockfiles #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrcjkb
force-pushed
the
mj/push-nllzlmkmvskx
branch
3 times, most recently
from
5443072 to
06db5af
Compare
|
Todos:
|
mrcjkb
force-pushed
the
mj/push-nllzlmkmvskx
branch
5 times, most recently
from
5700eb0 to
67a1a1f
Compare
mrcjkb
changed the title
mrcjkb
force-pushed
the
mj/push-nllzlmkmvskx
branch
5 times, most recently
from
a4add10 to
9443d3d
Compare
|
This should nicely pave way for |
mrcjkb
force-pushed
the
mj/push-nllzlmkmvskx
branch
2 times, most recently
from
0b9987c to
e7491c8
Compare
|
looks like the new test is failing in CI 😩 |
mrcjkb
force-pushed
the
mj/push-nllzlmkmvskx
branch
from
e7491c8 to
16b67c7
Compare
Should hopefully be fixed in #328. |
vhyrro
previously approved these changes
Jan 12, 2025
vhyrro
previously approved these changes
Jan 13, 2025
|
ouch, conflicts. they don't appear to be too difficult, though. want me to tackle these? |
sure :) |
vhyrro
force-pushed
the
mj/push-nllzlmkmvskx
branch
from
5bf59f6 to
28e800e
Compare
|
Okay, all done. Tests pass on my machine, let's see what the CI says. |
|
ready to merge when you are @mrcjkb :p |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
RocksPackageDBimplementation using a lockfile.Breaking:
rocks buildit now builds the current project,using a clone of the rockspec with the project root as the source.
This is now equivalent to
luarocks makeorcargo build.install-rockspeccommand for installing local rockspecs.--forceflag, because if we're building from a project or local rockspec, we probably always want to force.