Task nxp 32775 retention align 2025 #184
Open
+106
−67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guirenard
force-pushed
the
task-NXP-32775-retentionAlign-2025
branch
from
1724a54 to
c24c3b4
Compare
guirenard
force-pushed
the
task-NXP-32775-retentionAlign-2025
branch
from
c24c3b4 to
a4c37f0
Compare
kevinleturc
reviewed
Jan 9, 2025
Comment on lines
+91
to
+95
| <dependency> | ||
| <groupId>org.nuxeo.ecm.platform</groupId> | ||
| <artifactId>nuxeo-search-core</artifactId> | ||
| <scope>test</scope> | ||
| </dependency> |
There was a problem hiding this comment.
For information, this is a transitive dependency of nuxeo-platform-query-api which is already in the compile scope.
| @@ -132,7 +132,7 @@ public void saveRetainUntil(Calendar retainUntil) { | |||
| } | |||
|
|
|||
| public void setRule(RetentionRule rule, CoreSession session) { | |||
| setRuleIds(Arrays.asList(rule.getDocument().getId())); | |||
| setRuleIds(Collections.singletonList(rule.getDocument().getId())); | |||
There was a problem hiding this comment.
Suggested change
| setRuleIds(Collections.singletonList(rule.getDocument().getId())); | |
| setRuleIds(List.of(rule.getDocument().getId())); |
Comment on lines
+219
to
+224
| LogEntry entry = LogEntry.builder(name, new Date()) | ||
| .category(RetentionConstants.EVENT_CATEGORY) | ||
| .principalName(session.getPrincipal().getName()) | ||
| .comment(evctx.getInput()) | ||
| .build(); | ||
| Framework.getService(AuditBackend.class).addLogEntries(Collections.singletonList(entry)); |
There was a problem hiding this comment.
This is not a good idea (for all Nuxeo versions), this should be done by the audit itself by contributing to `"org.nuxeo.audit.service.AuditComponent#event".
Comment on lines
+38
to
+45
| @Deploy("org.nuxeo.retention.core:OSGI-INF/retention-core-types.xml") | ||
| @Deploy("org.nuxeo.retention.core:OSGI-INF/retention-adapters.xml") | ||
| @Deploy("org.nuxeo.retention.core:OSGI-INF/retention-vocabularies.xml") | ||
| @Deploy("org.nuxeo.retention.core:OSGI-INF/retention-content-template.xml") | ||
| @Deploy("org.nuxeo.retention.core:OSGI-INF/retention-service-framework.xml") | ||
| @Deploy("org.nuxeo.retention.core:OSGI-INF/retention-listeners.xml") | ||
| @Deploy("org.nuxeo.retention.core:OSGI-INF/retention-operations.xml") | ||
| @Deploy("org.nuxeo.retention.core:OSGI-INF/retention-actions.xml") |
There was a problem hiding this comment.
Not just @Deploy("org.nuxeo.retention.core")?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.