fix: optimise isFee

nutsfinance · Feb 21, 2025 · b5b9278 · b5b9278
1 parent 5a3da22
commit b5b9278
Showing 1 changed file with 10 additions and 14 deletions.
diff --git a/src/SelfPeggingAsset.sol b/src/SelfPeggingAsset.sol
@@ -1103,23 +1103,19 @@ contract SelfPeggingAsset is Initializable, ReentrancyGuardUpgradeable, OwnableU
         balances = _balances;
         totalSupply = newD;
 
-        if (isFee) {
-            if (oldD > newD && (oldD - newD) < feeErrorMargin) {
-                return 0;
-            } else if (oldD > newD) {
-                // Cover losses using the buffer
-                poolToken.removeTotalSupply(oldD - newD, true, true);
-                return 0;
-            }
-        } else {
-            if (oldD > newD && (oldD - newD) < yieldErrorMargin) {
-                return 0;
-            } else if (oldD > newD) {
-                // Cover losses using the buffer
-                poolToken.removeTotalSupply(oldD - newD, true, true);
+        if (oldD > newD) {
+            uint256 delta = oldD - newD;
+            uint256 margin = isFee ? feeErrorMargin : yieldErrorMargin;
+
+            if (delta < margin) {
                 return 0;
             }
+
+            // Cover losses using the buffer
+            poolToken.removeTotalSupply(delta, true, true);
+            return 0;
         }
+
         uint256 feeAmount = newD - oldD;
         if (feeAmount == 0) {
             return 0;