[Edwin] iP #191

yzhedwin · 2021-09-01T09:32:40Z

No description provided.

astralum

Good adherence to coding standards!

astralum · 2021-09-03T04:42:10Z

src/main/java/Duke.java

+                    }
+                }
+                System.out.println(border);
+


May not need an extra newline here

huien77

I can see some deep nesting and I think it would be good to create more methods to solve that
I also find some magic numbers, it would be good to avoid them
Overall, very good

huien77 · 2021-09-03T05:39:12Z

src/main/java/Duke.java

+            + "|_____| | ||_____| \n";
+    private static String border = "____________________________________________________________\n";
+
+    public static void addedTaskMessage(Task task) {


does it need to be past tense?

huien77 · 2021-09-03T05:44:06Z

src/main/java/Duke.java

+        String line;
+        printStartMessage();
+
+        do {


maybe can move the while loop to a new method, and call that method instead, following single level of abstraction

huien77 · 2021-09-03T06:34:01Z

src/main/java/Duke.java

+                int j = 1;
+                System.out.println(border);
+                System.out.println("Here is your list");
+
+                for (Task item : items) {
+                    if (item != null) {
+                        System.out.print(j + ".");
+                        System.out.println(item);
+                        j++;
+                    }
+                }


can consider moving this to a new method, might look neater, and no need so many level of indentation

huien77 · 2021-09-03T06:40:40Z

src/main/java/Duke.java

+                }
+                System.out.println(border);
+
+            } else if (line.length() > 4 && line.substring(0,4).contains("done")) {


avoid magic number like 4, instead store them as constants

stephlewyh · 2021-09-19T09:12:20Z

src/main/java/duke/Duke.java

+    private static final int FOUR = 4;
+    private static final int FIVE = 5;
+    private static final int SIX = 6;;
+    private static final int EIGHT = 8;
+    private static final int NINE = 9;


These string constants to refer to an integer may seem redundant and self-explanatory.
If you are working to replace them with magic numbers I would suggest more meaningful names.

stephlewyh · 2021-09-19T09:16:08Z

src/main/java/duke/Duke.java

+        System.out.println("Type bye to exit\n" + border);
+    }
+    public static boolean isInvalid(CommandList task, String line , String key) {
+        if (!line.split(key)[1].trim().isEmpty()) {


This expression is a little complicated - calling 3 methods and a negation. See how to improve the quality of expressions here.

stephlewyh · 2021-09-19T09:19:07Z

src/main/java/duke/Duke.java

+        try {
+            if (saveFile.createNewFile()) {
+                System.out.println("Successfully created save file");
+            } else {
+                System.out.println("Save file already exists");
+            }
+        } catch (IOException e) {
+            e.printStackTrace();


How about including the previous statements in the try catch block? After all, this method is doing file related operations and the program could catch file related exceptions.

stephlewyh · 2021-09-19T09:22:37Z

src/main/java/duke/Duke.java

+                fw.write(saveList.toString().charAt(1) + "/");
+                fw.write(saveList.getStatus() + "/" + saveList.getDescription());


For the parameters to the file writer, you could have declared variables for each for them to improve readability. E.g. fileStatus = saveList.getStatus().

stephlewyh · 2021-09-19T09:28:05Z

src/main/java/duke/Duke.java

+        System.out.println("Save file successfully loaded");
+    }
+
+    public static String readCommand(Scanner in, CommandList task, DukeException error) {


This method is parsing the command string, but it is not obvious how it is done with seemingly arbitrary constants like FOUR FIVE EIGHT etc. You could consider a more direct way of comparing strings and checking parameters.

stephlewyh · 2021-09-19T09:29:31Z

src/main/java/duke/command/CommandList.java

+    public void executeCommand(ArrayList<Task> items, DukeException error, String input) {
+        String[] inputs;
+        switch (command) {
+            case CMD_TODO:


This deviates from the switch case statement layout conventions - indentation for case is not needed.

stephlewyh · 2021-09-19T09:31:06Z

src/main/java/duke/command/CommandList.java

+            case CMD_EVENT:
+                inputs = input.split(AT);
+                addEvent(items, inputs[0].trim().replace(EVENT, "").trim(), inputs[1].trim());
+                addTaskMessage(items.get(taskCount));
+                break;
+            case CMD_DEADLINE:
+                inputs = input.split(BY);
+                addDeadline(items, inputs[0].trim().replace(DEADLINE, "").trim(), inputs[1].trim());
+                addTaskMessage(items.get(taskCount));
+                break;
+            case CMD_LIST:
+                int j = 1;
+                System.out.println(border);
+                System.out.println("Here are the task in your list:");
+                for (Task item : items) {
+                    if (item != null) {
+                        System.out.print(j + ".");
+                        System.out.println(item);
+                        j++;
+                    }
+                }
+                break;
+            case CMD_DONE:
+                int dividerPosition = input.indexOf(" ") + 1;
+                int endPosition = input.length();
+                if (endPosition > FIVE) {
+                    String num = input.substring(dividerPosition, endPosition);
+                    int taskNum = Integer.parseInt(num) - 1;
+                    items.get(taskNum).markDone();
+                    System.out.println(border + "Nice! task is done " + '\n' + border);
+                }
+                break;
+            case CMD_TERMINATE:
+                printEndMessage();
+                break;
+            case CMD_DELETE:
+                dividerPosition = input.indexOf(" ") + 1;
+                endPosition = input.length();
+                if (endPosition > SEVEN) {
+                    String num = input.substring(dividerPosition, endPosition);
+                    int taskNum = Integer.parseInt(num) - 1;
+                    removeItem(items, taskNum);
+                }
+                break;
+            default:
+                printErrorMessage(error);
+                break;
+        }


While you have organized different procedure into separate cases, the executeCommand method is still rather long. How about trying SLAP principle here?

stephlewyh · 2021-09-19T09:32:23Z

src/main/java/duke/Duke.java

+        }
+    }
+
+    private static void readSave(CommandList task) throws FileNotFoundException {


It would be good to provide method descriptions as comments/javadocs to improve code readability.

Added Date and Time functionality

Added Find Feature

Documentation for A-JavaDoc

yzhedwin added 5 commits August 23, 2021 00:23

Week 2 Task

bcf20ee

Level-1

2c2a310

Level-2

da7c42b

Level-3

7e2f13a

Completed A-CodingStandard

0b9ce39

astralum reviewed Sep 3, 2021

View reviewed changes

src/main/java/Duke.java Outdated

}

}

System.out.println(border);

Copy link

astralum Sep 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May not need an extra newline here

yzhedwin added 2 commits September 3, 2021 13:26

Level-4 Completed

074899d

Level-4, A-CodeQuality

4ce8ac0

huien77 reviewed Sep 3, 2021

View reviewed changes

yzhedwin added 16 commits September 7, 2021 10:19

Completed Level-5

c2a8cf3

Completed Level-5,A-Exceptions

e61f1e7

Updated Ui Testing

daef42c

Created new branch as part of increments

3fc7b81

Merge branch-Level-5 with master

ed20d64

Completed A-Packages and improve coding standards

e8ce66f

Merge branch-A-Packages with master

acfd97c

Updated runtest.bat

88ad15e

Formatted some codes

d3cbc29

Code Fixes

b573d4c

Improved A-Exception

3974bd3

Added delete feature

22af079

Added save feature and some personality for Level-7 requirement

3c647fc

Minor changes to save.txt

a294af8

Merge branch Level-6 with master

86a9032

Merge branch Level-7 with master

c3af9c5

stephlewyh reviewed Sep 19, 2021

View reviewed changes

yzhedwin and others added 4 commits September 28, 2021 02:16

Added more OOP and fixed exception handling

92cbe7d

Added Date and Time functionality

ea44036

Merge pull request #1 from yzhedwin/branch-Level-8

d57c1a3

Added Date and Time functionality

Added Find Feature

a2984d6

yzhedwin and others added 9 commits September 29, 2021 12:24

Merge pull request #2 from yzhedwin/branch-Level-9

4a890e0

Added Find Feature

Documentation for A-JavaDoc

8a47b70

Merge pull request #3 from yzhedwin/branch-A-JavaDoc

5217ca0

Documentation for A-JavaDoc

Updated JavaDoc

d3eb8f0

Completed User Guide

468e2f1

Set theme jekyll-theme-cayman

9c9496a

Completed User Guide

0f9c8b7

Merge branch 'master' of github.com:yzhedwin/ip

788449d

Build ip.jar

e8616f6

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Edwin] iP #191

[Edwin] iP #191

yzhedwin commented Sep 1, 2021

astralum left a comment

astralum Sep 3, 2021

huien77 left a comment

huien77 Sep 3, 2021

huien77 Sep 3, 2021

huien77 Sep 3, 2021

huien77 Sep 3, 2021

stephlewyh Sep 19, 2021

stephlewyh Sep 19, 2021

stephlewyh Sep 19, 2021

stephlewyh Sep 19, 2021

stephlewyh Sep 19, 2021

stephlewyh Sep 19, 2021

stephlewyh Sep 19, 2021

stephlewyh Sep 19, 2021

		fw.write(saveList.toString().charAt(1) + "/");
		fw.write(saveList.getStatus() + "/" + saveList.getDescription());

[Edwin] iP #191

Are you sure you want to change the base?

[Edwin] iP #191

Conversation

yzhedwin commented Sep 1, 2021

astralum left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

huien77 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment