[Huang Che Yen] iP #180

KaiserHuang88 · 2021-09-01T02:06:32Z

No description provided.

richwill28

Overall, code looks good. There are only several coding standard violations.

richwill28 · 2021-09-01T03:32:52Z

src/main/java/Duke.java

 public class Duke {
+
+    private static boolean diff_string_check(String[] arr, String toCheckValue)
+    {


This seems to be a violation of the coding standard, more specifically consider using K&R style brackets. I noticed the same issue in several places below too.

richwill28 · 2021-09-01T03:37:16Z

src/main/java/Duke.java

@@ -1,10 +1,85 @@
+import java.util.Arrays;


Unused import. Consider removing this line, it would make the code cleaner.

richwill28 · 2021-09-01T03:40:35Z

src/main/java/Duke.java

+            {
+                for (int i = 0; i < total_tasks; i += 1)
+                {
+                    System.out.print((i+1) + "." + "[" + schedule[i].getStatusIcon() + "] ");


+ is not followed and preceded by whitespace. This is a violation of the coding standard, more specifically the White space within a statement guideline.

richwill28

Code looks good so far. One improvement to be consider is to create subclasses of Task. For example, adding Todo, Deadline, and Event classes to improve the feature of the app.

richwill28 · 2021-09-01T04:23:11Z

src/main/java/Task.java

+        this.isDone = false;
+    }
+
+    public void markAsDone()


Consider writing a JavaDoc comment for public methods, as it is meant to be used by others. This seems to be a violation of this coding standard, more specifically it is advisable to write descriptive header comments for all public classes/methods.

aditichadha1310 · 2021-09-01T04:49:27Z

src/main/java/Duke.java

+
+    private static boolean diff_string_check(String[] arr, String toCheckValue)
+    {
+        boolean test = true;


You might want to name a boolean variable with something that starts with is or has? It will then follow the coding standards.

aditichadha1310 · 2021-09-01T04:51:50Z

src/main/java/Duke.java

+            if (toCheckValue.equals(arr[i]))
+            {
+                test = false;
+                break;
+            }
+            else if (arr[i] == null)
+            {
+                break;
+            }
+        }


Perhaps this violates the coding standards. You can write the code as follows:
if(){

--
} else if(){

} else{

--
}

Mist0919 · 2021-09-04T13:48:48Z

src/main/java/Task.java

+    public String getStatusIcon()
+    {
+        return (isDone ? "X" : " "); // mark done task with X
+    }


The first "{" of each method should be next to the name of method.
eg. public String getStatusIcon() {
......
}

xseh

Good try, consider following the coding standard a little more and SLAP more

xseh · 2021-09-18T19:23:51Z

src/main/java/Duke.java

+    {
+        boolean test = true;
+
+        for (int i = 0; i < arr.length; i++)


Follow Egyptian style brackets.

xseh · 2021-09-18T19:29:18Z

src/main/java/Duke.java

+            }
+
+            //Done
+            else if ((line.length() > 4) && line.substring(0, 4).equals("done"))


Avoid complicated expressions. Consider splitting the complicated expressions into steps. or use SLAP to extract the logic into separate functions.

xseh · 2021-09-18T19:32:22Z

src/main/java/Duke.java

+            //Done
+            else if ((line.length() > 4) && line.substring(0, 4).equals("done"))
+            {
+                int number = Character.getNumericValue(line.charAt(5));


Consider a more meaningful name than number which can better describe the value.

Also avoid the use of magic literals. Using a suitable variable name for the constant numbers (which describes the value) would help the understanding of the program.

xseh · 2021-09-18T19:35:05Z

src/main/java/Duke.java

+                schedule[number - 1].markAsDone();
+            }
+
+            // Check for duplicates and add accordingly


Consider removing the comment since the code seems self-explanatory.

xseh · 2021-09-18T19:49:41Z

src/main/java/Duke.java

+            // Check for duplicates and add accordingly
+            else if (diff_string_check(task_list, line))
+            {
+                Task t = new Task(line);


Consider using a more suitable name (noun) instead of an alphabet for the variable.

xseh · 2021-09-18T19:49:57Z

src/main/java/Duke.java

+            {
+                Task t = new Task(line);
+                schedule[total_tasks] = t;
+                task_list[total_tasks] = line;


Variable names must be in camelCase.

xseh · 2021-09-18T19:52:15Z

src/main/java/Duke.java

+            }
+
+            // Check for duplicates and add accordingly
+            else if (diff_string_check(task_list, line))


Names representing methods must be verbs and written in camelCase.

A-JavaDoc

KaiserHuang88 added 6 commits August 29, 2021 16:11

changed a bit of Duke

3d9a6ea

Level0

a796e54

Level-1

be4fd76

Level-2

b34b84a

Level-3

2aaa7f9

Added Task Class

d2350a0

richwill28 reviewed Sep 1, 2021

View reviewed changes

aditichadha1310 reviewed Sep 1, 2021

View reviewed changes

Mist0919 reviewed Sep 4, 2021

View reviewed changes

xseh reviewed Sep 18, 2021

View reviewed changes

KaiserHuang88 and others added 19 commits September 19, 2021 11:14

Level-4

68eb33e

Level-5

ff9c808

Updated Duke.java

f06cd83

Updated Level 5

c8f5955

Added Logo

602c96a

Level-5

7a2d83d

Logo a bit changed

0dd58cb

Level-7

7d92f8a

Level-9

d18a3aa

A-MoreOOP

deab377

Update README.md

c826c27

Update README.md

a62a8de

Update README.md

55130c9

Update README.md

57a47c8

Update README.md

7f8faed

Update README.md

cc007cf

Update README.md

9ee1821

Update README.md

39cd289

Update README.md

f3bcdff

KaiserHuang88 added 26 commits October 1, 2021 17:27

Update README.md

7986b08

Update README.md

037380d

Update README.md

92b56e9

Update README.md

5e3952f

Update README.md

5d138bf

Update README.md

2ad011f

Update README.md

0095d95

Update README.md

f66a76b

Update README.md

6688a2c

Update README.md

5b2d8e7

Update README.md

333b755

Update README.md

cf9f9f5

Update README.md

e3c0344

A-CodingStandard

0f87d12

Merge branch 'master' of https://github.com/KaiserHuang88/ip

43d64e2

A-JavaDoc

873a8dd

Merge pull request #2 from KaiserHuang88/branch-A-JavaDoc

556dc1c

A-JavaDoc

A-Exceptions

e131db1

A-Collections

d1a0f31

A-UserGuide

8feaa3c

A-JavaDoc

bc71c65

Merge branch 'master' of https://github.com/KaiserHuang88/ip

f36a9d8

Cleaning up

b5a2e35

Final touchup

c067707

Finalised

a73d161

Set theme jekyll-theme-cayman

b5da5bf

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Huang Che Yen] iP #180

[Huang Che Yen] iP #180

KaiserHuang88 commented Sep 1, 2021

richwill28 left a comment

richwill28 Sep 1, 2021 •

edited

Loading

richwill28 Sep 1, 2021 •

edited

Loading

richwill28 Sep 1, 2021

richwill28 left a comment

richwill28 Sep 1, 2021 •

edited

Loading

aditichadha1310 Sep 1, 2021

aditichadha1310 Sep 1, 2021

Mist0919 Sep 4, 2021

xseh left a comment

xseh Sep 18, 2021

xseh Sep 18, 2021

xseh Sep 18, 2021

xseh Sep 18, 2021

xseh Sep 18, 2021

xseh Sep 18, 2021

xseh Sep 18, 2021

[Huang Che Yen] iP #180

Are you sure you want to change the base?

[Huang Che Yen] iP #180

Conversation

KaiserHuang88 commented Sep 1, 2021

richwill28 left a comment

Choose a reason for hiding this comment

richwill28 Sep 1, 2021 • edited Loading

Choose a reason for hiding this comment

richwill28 Sep 1, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

richwill28 left a comment

Choose a reason for hiding this comment

richwill28 Sep 1, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Perhaps this violates the coding standards. You can write the code as follows: if(){

-- } else if(){

} else{

Choose a reason for hiding this comment

xseh left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

richwill28 Sep 1, 2021 •

edited

Loading

richwill28 Sep 1, 2021 •

edited

Loading

richwill28 Sep 1, 2021 •

edited

Loading

Perhaps this violates the coding standards. You can write the code as follows:
if(){

--
} else if(){