Améliorations du composant "Section promotionnelle" #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ash-Crow
commented
Dec 7, 2023
| @@ -158,9 +158,9 @@ | |||
| # https://whitenoise.evans.io/en/latest/ | |||
|
|
|||
| STATICFILES_FINDERS = [ | |||
| "django.contrib.staticfiles.finders.FileSystemFinder", | |||
There was a problem hiding this comment.
J'ai dû mettre les fichiers dans le même ordre que la doc de django-sass-processor sinon il ne trouvait pas le fichier https://github.com/jrief/django-sass-processor/blob/master/README.md
mjeammet
reviewed
Dec 12, 2023
Comment on lines
+3
to
+13
| <div class="cmsfr-hero{% if block.value.large %} cmsfr-hero-large{% endif %}{% if block.value.darken %} cmsfr-hero-dark{% endif %}" | ||
| style="background-image: {% if block.value.darken %}linear-gradient(rgba(0,0,0,0.7), rgba(0,0,0,0.7)), {% endif %}url({{ bg_img.url }}); | ||
| background-color: {{ block.value.bg_color }}; | ||
| "> | ||
| <div class="fr-container fr-py-14w"> | ||
| <div class="fr-grid-row fr-grid-row--gutters"> | ||
| <div class="fr-col fr-col-12 fr-col-md-6"> | ||
| <h1>{{ block.value.title }}</h1> | ||
| <div class="fr-col fr-col-12{% if not block.value.large %}fr-col-md-6{% endif %}"> | ||
| <h1{% if block.value.large%} class="fr-display--sm"{% endif %}>{{ block.value.title }}</h1> | ||
| {% if block.value.text %}<p>{{ block.value.text }}</p>{% endif %} | ||
| {% if block.value.cta_link and block.value.cta_label %} | ||
| <a class="fr-btn fr-btn--primary fr-btn--lg" | ||
| <a class="fr-btn {% if block.value.darken %}fr-btn--secondary fr-background-alt--blue-france fr-btn--lg{% else %}fr-btn--primary{% endif %} fr-btn--lg" |
There was a problem hiding this comment.
Bon, je ne connais aucune de ces classes mais j'ai grande confiance !
There was a problem hiding this comment.
Tu peux voir le résultat sur la capture d'écran (en mode "assombrir", le bouton est plus pâle sinon ça manque de contraste)
mjeammet
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Objectif
Le composant "Section promotionnelle" a des limitations, qui peuvent être levées en le rendant plus modulaire pour permettre d'obtenir un rendu similaire à celui utilisé sur le site du CNR : https://conseil-refondation.fr/
🔍 Implémentation
🏕 Amélioration continue
🖼️ Images