Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clean up metrics for deleted mvtx #2338

Merged
merged 4 commits into from
Jan 19, 2025
Merged

fix: clean up metrics for deleted mvtx #2338

merged 4 commits into from
Jan 19, 2025

Conversation

whynowy
Copy link
Member

@whynowy whynowy commented Jan 19, 2025

Closes: #2336

  1. Clean up mvtx related metrics with best effort
  2. Always use finalizer for ISBSvc regardless of pvc used or not, so that it can be used to do all the clean up.

.
Signed-off-by: Derek Wang <[email protected]>
.
Signed-off-by: Derek Wang <[email protected]>
@whynowy whynowy requested a review from vigith as a code owner January 19, 2025 06:13
.
Signed-off-by: Derek Wang <[email protected]>
Copy link

codecov bot commented Jan 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.58%. Comparing base (d544908) to head (206c4f4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2338      +/-   ##
==========================================
+ Coverage   67.48%   67.58%   +0.09%     
==========================================
  Files         351      351              
  Lines       45929    45924       -5     
==========================================
+ Hits        30994    31036      +42     
+ Misses      13860    13807      -53     
- Partials     1075     1081       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@whynowy whynowy merged commit 3707673 into numaproj:main Jan 19, 2025
25 checks passed
@whynowy whynowy deleted the dss branch January 19, 2025 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up metrics for deleted objects.
2 participants