Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: expose pending messages metric in async pipeline #2330

Merged
merged 5 commits into from
Jan 15, 2025
Merged

feat: expose pending messages metric in async pipeline #2330

merged 5 commits into from
Jan 15, 2025

Conversation

yhl25
Copy link
Contributor

@yhl25 yhl25 commented Jan 14, 2025

No description provided.

@codecov Codecov
Copy link

codecov bot commented Jan 14, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 91.56627% with 21 lines in your changes missing coverage. Please review.

Project coverage is 67.12%. Comparing base (2653fb2) to head (b71ff0c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
rust/numaflow-core/src/metrics.rs 93.75% 13 Missing ⚠️
...numaflow-core/src/pipeline/isb/jetstream/reader.rs 66.66% 4 Missing ⚠️
rust/numaflow-core/src/pipeline.rs 85.71% 3 Missing ⚠️
rust/numaflow-core/src/monovertex.rs 80.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2330      +/-   ##
==========================================
- Coverage   67.20%   67.12%   -0.08%     
==========================================
  Files         351      351              
  Lines       45316    45496     +180     
==========================================
+ Hits        30455    30541      +86     
- Misses      13783    13874      +91     
- Partials     1078     1081       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yhl25 yhl25 marked this pull request as ready for review January 15, 2025 03:29
@yhl25 yhl25 requested review from whynowy and vigith as code owners January 15, 2025 03:29
vigith added 2 commits January 14, 2025 19:58
@vigith
chore: fmt StdExternalCrate
c79dc9f 
Signed-off-by: Vigith Maurice <[email protected]>
@vigith
chore: use enum
facd0e6 
Signed-off-by: Vigith Maurice <[email protected]>
@yhl25 yhl25 merged commit fd4a0aa into main Jan 15, 2025
28 checks passed
@yhl25 yhl25 deleted the pending branch January 15, 2025 04:25
SaniyaKalamkar pushed a commit to SaniyaKalamkar/numaflow that referenced this pull request Jan 19, 2025
@yhl25 @vigith @SaniyaKalamkar
feat: expose pending messages metric in async pipeline (numaproj#2330)
5343e59 
Signed-off-by: Yashash H L <[email protected]>
Signed-off-by: Vigith Maurice <[email protected]>
Co-authored-by: Vigith Maurice <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vigith vigith vigith approved these changes

@whynowy whynowy Awaiting requested review from whynowy whynowy is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yhl25 @vigith