chore: skip publishing the last empty struct when generator stops #2327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation Signed-off-by: Keran Yang <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2327 +/- ##
==========================================
- Coverage 67.09% 67.08% -0.02%
==========================================
Files 351 351
Lines 45269 45272 +3
==========================================
- Hits 30375 30372 -3
- Misses 13825 13829 +4
- Partials 1069 1071 +2 ☔ View full report in Codecov by Sentry. |
whynowy
reviewed
Jan 13, 2025
pkg/sources/generator/tickgen.go
Outdated
| // when the channel is closed and empty, go will still read from the channel once and return the zero value. | ||
| // exclude the zero value from being passed to the next vertex, | ||
| // ensuring all messages produced by generator follow the same data schema. | ||
| if util.IsZeroStruct(r) { |
There was a problem hiding this comment.
Thanks! I updated the PR description and addressed the comment. Don't need the isZero check, just use the second parameter should work.
Signed-off-by: Keran Yang <[email protected]>
whynowy
reviewed
Jan 13, 2025
pkg/sources/generator/tickgen.go
Outdated
| // ensuring all messages produced by generator follow the same data schema. | ||
| if !ok { | ||
| mg.logger.Info("Zero value read from the generator channel, skipping...") | ||
| continue |
There was a problem hiding this comment.
In this case, shall we return instead of continue?
Signed-off-by: Keran Yang <[email protected]>
whynowy
approved these changes
Jan 13, 2025
SaniyaKalamkar
pushed a commit
to SaniyaKalamkar/numaflow
that referenced
this pull request
Jan 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2285
There is race condition when we terminate the generator vertex. The message channel can be closed followed by a read from the channel. Reading from a closed channel will return the zero value of the struct, resulting in an empty message being sent to the next vertex. This change prevent it from being sent so that we have a consistent data structure for downstream vertices.