fix: lastScaledAt not updated during autoscaling down #2323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Wang <[email protected]>
whynowy
commented
Jan 12, 2025
| @@ -300,7 +301,6 @@ func (r *vertexReconciler) orchestratePods(ctx context.Context, vertex *dfv1.Ver | |||
| } | |||
| } | |||
|
|
|||
| currentReplicas := int(vertex.Status.Replicas) | |||
There was a problem hiding this comment.
This is the place to set lastScaledAt . Should not use current vertex.Status.Replicas as it has been updated above.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2323 +/- ##
==========================================
+ Coverage 67.16% 67.27% +0.10%
==========================================
Files 351 351
Lines 45273 45269 -4
==========================================
+ Hits 30408 30453 +45
+ Misses 13786 13744 -42
+ Partials 1079 1072 -7 ☔ View full report in Codecov by Sentry. |
whynowy
changed the title
vigith
approved these changes
Jan 12, 2025
SaniyaKalamkar
pushed a commit
to SaniyaKalamkar/numaflow
that referenced
this pull request
Jan 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain what this PR does.