feat: implement callbacks from vertices when serving is used as source #2311
+935
−293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sreekanth <[email protected]>
vigith
changed the title
Signed-off-by: Sreekanth <[email protected]>
yhl25
reviewed
Jan 13, 2025
Comment on lines
253
to
255
| if let Some(ref callback_handler) = this.callback_handler { | ||
| let metadata = message.metadata.ok_or_else(|| { | ||
| Error::Source(format!( |
There was a problem hiding this comment.
we should write the callback after pafs are resolved
There was a problem hiding this comment.
Will update. I wrongly assumed .resolve_pafs() would wait for them to resolve.
Signed-off-by: Sreekanth <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2311 +/- ##
==========================================
+ Coverage 67.47% 67.72% +0.25%
==========================================
Files 351 352 +1
Lines 45822 46306 +484
==========================================
+ Hits 30918 31363 +445
- Misses 13828 13868 +40
+ Partials 1076 1075 -1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Sreekanth <[email protected]>
Signed-off-by: Sreekanth <[email protected]>
Signed-off-by: Sreekanth <[email protected]>
Signed-off-by: Sreekanth <[email protected]>
Signed-off-by: Sreekanth <[email protected]>
Signed-off-by: Sreekanth <[email protected]>
Signed-off-by: Sreekanth <[email protected]>
Signed-off-by: Sreekanth <[email protected]>
Signed-off-by: Sreekanth <[email protected]>
yhl25
reviewed
Jan 17, 2025
rust/numaflow-core/src/tracker.rs
Outdated
| pub(crate) async fn update(&self, message: &Message) -> Result<()> { | ||
| let offset = message.id.offset.clone(); | ||
| let mut responses: Option<Vec<String>> = None; | ||
| if self.enable_callbacks { |
Signed-off-by: Sreekanth <[email protected]>
Signed-off-by: Sreekanth <[email protected]>
Signed-off-by: Sreekanth <[email protected]>
Signed-off-by: Sreekanth <[email protected]>
Signed-off-by: Sreekanth <[email protected]>
Signed-off-by: Sreekanth <[email protected]>
Signed-off-by: Sreekanth <[email protected]>
Signed-off-by: Sreekanth <[email protected]>
Signed-off-by: Sreekanth <[email protected]>
Signed-off-by: Sreekanth <[email protected]>
Signed-off-by: Sreekanth <[email protected]>
Signed-off-by: Sreekanth <[email protected]>
Signed-off-by: Sreekanth <[email protected]>
Signed-off-by: Sreekanth <[email protected]>
Signed-off-by: Sreekanth <[email protected]>
Signed-off-by: Sreekanth <[email protected]>
Signed-off-by: Sreekanth <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements callbacks to source vertex when Serving source is used. #2318