Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: move message conversions to appropriate modules #2306

Merged
merged 5 commits into from
Jan 2, 2025
Merged

chore: move message conversions to appropriate modules #2306

merged 5 commits into from
Jan 2, 2025

Conversation

yhl25
Copy link
Contributor

@yhl25 yhl25 commented Jan 2, 2025

No description provided.

@yhl25 yhl25 requested review from whynowy and vigith as code owners January 2, 2025 05:31
@yhl25 yhl25 requested a review from BulkBeing January 2, 2025 05:31
@codecov Codecov
Copy link

codecov bot commented Jan 2, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 97.60766% with 5 lines in your changes missing coverage. Please review.

Project coverage is 66.95%. Comparing base (bb4a0de) to head (12dcd25).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
rust/numaflow-core/src/message.rs 50.00% 2 Missing ⚠️
rust/numaflow-core/src/sink.rs 97.29% 2 Missing ⚠️
rust/numaflow-core/src/source/user_defined.rs 98.46% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2306      +/-   ##
==========================================
- Coverage   67.17%   66.95%   -0.23%     
==========================================
  Files         349      349              
  Lines       44992    45055      +63     
==========================================
- Hits        30222    30165      -57     
- Misses      13699    13817     +118     
- Partials     1071     1073       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

yhl25 and others added 3 commits January 2, 2025 11:18
@vigith vigith enabled auto-merge (squash) January 2, 2025 05:59
@yhl25
cargo fmt
12dcd25 
Signed-off-by: Yashash H L <[email protected]>
@vigith vigith merged commit 0c86e82 into main Jan 2, 2025
28 checks passed
@vigith vigith deleted the rfr branch January 2, 2025 06:49
SaniyaKalamkar pushed a commit to SaniyaKalamkar/numaflow that referenced this pull request Jan 19, 2025
@yhl25 @vigith @SaniyaKalamkar
chore: move message conversions to appropriate modules (numaproj#2306)
96689b8 
Signed-off-by: Yashash H L <[email protected]>
Signed-off-by: Vigith Maurice <[email protected]>
Co-authored-by: Vigith Maurice <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vigith vigith vigith approved these changes

@whynowy whynowy Awaiting requested review from whynowy whynowy is a code owner

@BulkBeing BulkBeing Awaiting requested review from BulkBeing

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yhl25 @vigith