chore: use domain-qualified finalizer name #2304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Wang <[email protected]>
vigith
approved these changes
Dec 25, 2024
| @@ -41,7 +41,9 @@ import ( | |||
| ) | |||
|
|
|||
| const ( | |||
| finalizerName = dfv1.ControllerISBSvc | |||
| finalizerName = "numaflow.numaproj.io/" + dfv1.ControllerISBSvc | |||
| // TODO: clean up the deprecated finalizer in v1.7 | |||
There was a problem hiding this comment.
Suggested change
| // TODO: clean up the deprecated finalizer in v1.7 | |
| // DEPRECATE(1.7): clean up the deprecated finalizer in v1.7 |
Is this a simpler search pattern?
There was a problem hiding this comment.
Might get confused with Deprecated annotation. We could search Deprecated in the future.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2304 +/- ##
==========================================
+ Coverage 67.11% 67.13% +0.01%
==========================================
Files 349 349
Lines 44961 44969 +8
==========================================
+ Hits 30175 30188 +13
+ Misses 13716 13712 -4
+ Partials 1070 1069 -1 ☔ View full report in Codecov by Sentry. |
SaniyaKalamkar
pushed a commit
to SaniyaKalamkar/numaflow
that referenced
this pull request
Jan 19, 2025
Signed-off-by: Derek Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using non domain-qualified finalizer name might cause a warning.
https://github.com/kubernetes/kubernetes/blob/f836773540cc83488250a12637e7d924078ef284/staging/src/k8s.io/apiextensions-apiserver/pkg/registry/customresource/validator.go#L89