Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use same metric to expose binary build info #2293

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

whynowy
Copy link
Member

@whynowy whynowy commented Dec 17, 2024

# HELP build_info A metric with a constant value '1', labeled by Numaflow binary version, platform, and other information
# TYPE build_info gauge
build_info{component="daemon",component_name="simple-pipeline",platform="linux/arm64",version="latest+7450e16.dirty"} 1

# HELP pipeline_build_info A metric with a constant value '1', labeled by Numaflow binary version and platform, as well as the pipeline name. Deprecated: Use build_info instead
# TYPE pipeline_build_info gauge
pipeline_build_info{pipeline="simple-pipeline",platform="linux/arm64",version="latest+7450e16.dirty"} 1

@whynowy whynowy requested a review from vigith as a code owner December 17, 2024 22:55
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 65.74%. Comparing base (7450e16) to head (6560e81).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/daemon/server/daemon_server.go 0.00% 3 Missing ⚠️
pkg/mvtxdaemon/server/daemon_server.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2293      +/-   ##
==========================================
+ Coverage   65.50%   65.74%   +0.23%     
==========================================
  Files         346      346              
  Lines       42493    42497       +4     
==========================================
+ Hits        27837    27939     +102     
+ Misses      13580    13487      -93     
+ Partials     1076     1071       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@whynowy whynowy merged commit 40ecf06 into numaproj:main Dec 18, 2024
25 checks passed
@whynowy whynowy deleted the hell branch December 18, 2024 05:14
SaniyaKalamkar pushed a commit to SaniyaKalamkar/numaflow that referenced this pull request Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants