fix: set max decode size of proto message, add mvtx metrics #2283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yashash H L <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2283 +/- ##
==========================================
- Coverage 65.57% 65.55% -0.02%
==========================================
Files 346 346
Lines 42396 42476 +80
==========================================
+ Hits 27800 27845 +45
- Misses 13528 13559 +31
- Partials 1068 1072 +4 ☔ View full report in Codecov by Sentry. |
vigith
reviewed
Dec 13, 2024
I think 5 is less, I have increased the retry count to 60 (1000ms * 60). |
vigith
reviewed
Dec 16, 2024
| @@ -90,7 +90,7 @@ pub(crate) fn prost_timestamp_from_utc(t: DateTime<Utc>) -> Option<Timestamp> { | |||
|
|
|||
| pub(crate) async fn create_rpc_channel(socket_path: PathBuf) -> error::Result<Channel> { | |||
| const RECONNECT_INTERVAL: u64 = 1000; | |||
| const MAX_RECONNECT_ATTEMPTS: usize = 5; | |||
| const MAX_RECONNECT_ATTEMPTS: usize = 60; | |||
There was a problem hiding this comment.
does this print for every retry? else users might think why it is hanging. please print a error! for every retry?
There was a problem hiding this comment.
I added a warn! between the retries, if the retries are exhausted we print error!.
Signed-off-by: Yashash H L <[email protected]>
vigith
approved these changes
Dec 16, 2024
Signed-off-by: Yashash H L <[email protected]>
SaniyaKalamkar
pushed a commit
to SaniyaKalamkar/numaflow
that referenced
this pull request
Jan 19, 2025
…#2283) Signed-off-by: Yashash H L <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.