Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make unit and display name configurable #2269

Merged
merged 8 commits into from
Jan 8, 2025

Conversation

adarsh0728
Copy link
Contributor

@adarsh0728 adarsh0728 commented Dec 9, 2024

Resolves #2268
Resolves #2279

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.28%. Comparing base (0c86e82) to head (24a64a8).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2269      +/-   ##
==========================================
+ Coverage   67.08%   67.28%   +0.19%     
==========================================
  Files         349      351       +2     
  Lines       45055    45275     +220     
==========================================
+ Hits        30227    30463     +236     
+ Misses      13756    13743      -13     
+ Partials     1072     1069       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adarsh0728 adarsh0728 changed the title feat: Add legends to metric charts feat: make unit and display name configurable Dec 13, 2024
@adarsh0728
Copy link
Contributor Author

adarsh0728 commented Jan 3, 2025

  1. Latency metrics can have "s" and "ms" as units in config. If unset, then default behaviour. (second image has unit set as "ms").
  2. For other metrics, default behaviour is followed. (1st, 3rd, 4th images are following default behaviour).
  3. If display name is configured, then we show that display name, otherwise fallback to map name for that metric (if exists), else metric name itself is displayed.
Screenshot 2025-01-03 at 4 23 48 PM Screenshot 2025-01-03 at 4 24 02 PM Screenshot 2025-01-03 at 4 24 31 PM Screenshot 2025-01-03 at 4 24 44 PM

@adarsh0728 adarsh0728 requested a review from veds-g January 6, 2025 03:19
@adarsh0728 adarsh0728 marked this pull request as ready for review January 6, 2025 03:32
@vigith
Copy link
Member

vigith commented Jan 6, 2025

Screenshot 2025-01-03 at 4 23 48 PM

Can we align the on-hover display?

@adarsh0728
Copy link
Contributor Author

adarsh0728 commented Jan 8, 2025

Resolved comment. Below are the screenshots after the latest changes.

Screenshot 2025-01-08 at 2 38 20 PM Screenshot 2025-01-08 at 2 38 33 PM

@adarsh0728 adarsh0728 merged commit 5f5af1b into numaproj:main Jan 8, 2025
25 checks passed
@adarsh0728 adarsh0728 deleted the feat/add-legends-to-charts branch January 8, 2025 10:28
SaniyaKalamkar pushed a commit to SaniyaKalamkar/numaflow that referenced this pull request Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

metrics config map to accept units and display name Metrics does not have legends
2 participants