feat: mvtx gauge metrics support #2259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
veds-g
commented
Dec 5, 2024
•
veds-g
commented
vigith
approved these changes
Dec 5, 2024
veds-g
commented
Dec 5, 2024
| title: Pending Messages Lag | ||
| description: This query is the total number of pending messages for the mono vertex | ||
| expr: | | ||
| $metric_name{$filters} |
There was a problem hiding this comment.
will be adding support for operation like max, min or avg in query expression.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2259 +/- ##
==========================================
- Coverage 65.60% 65.51% -0.10%
==========================================
Files 346 346
Lines 42373 42373
==========================================
- Hits 27799 27759 -40
- Misses 13499 13544 +45
+ Partials 1075 1070 -5 ☔ View full report in Codecov by Sentry. |
whynowy
approved these changes
Dec 5, 2024
yhl25
reviewed
Dec 5, 2024
adarsh0728
reviewed
Dec 6, 2024
...partials/Pods/partials/PodDetails/partials/Metrics/partials/common/FiltersDropdown/index.tsx
Show resolved
Hide resolved
adarsh0728
reviewed
Dec 6, 2024
Signed-off-by: veds-g <[email protected]>
Signed-off-by: veds-g <[email protected]>
veds-g
force-pushed
the
gauge-metrics
branch
2 times, most recently
from
9d27795 to
f626686
Compare
Signed-off-by: veds-g <[email protected]>
veds-g
force-pushed
the
gauge-metrics
branch
from
f626686 to
bd74a37
Compare
adarsh0728
approved these changes
Dec 10, 2024
SaniyaKalamkar
pushed a commit
to SaniyaKalamkar/numaflow
that referenced
this pull request
Jan 19, 2025
Signed-off-by: veds-g <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.