Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added support for kafka OAuth authentication #2257

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

SzymonZebrowski
Copy link
Contributor

Adds support for Kafka SASL OAUTHBEARER authentication for kafka source and sink.

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 47.72727% with 23 lines in your changes missing coverage. Please review.

Project coverage is 67.26%. Comparing base (cd1fcb4) to head (3ae02e9).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
pkg/shared/util/sasl_config.go 47.72% 18 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2257      +/-   ##
==========================================
+ Coverage   67.16%   67.26%   +0.10%     
==========================================
  Files         351      351              
  Lines       45273    45313      +40     
==========================================
+ Hits        30408    30482      +74     
+ Misses      13786    13758      -28     
+ Partials     1079     1073       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vigith
Copy link
Member

vigith commented Jan 12, 2025

please mark as ready to review if you think the PR is ready.

@SzymonZebrowski SzymonZebrowski marked this pull request as ready for review January 14, 2025 08:53
@whynowy whynowy merged commit 2653fb2 into numaproj:main Jan 14, 2025
25 checks passed
SaniyaKalamkar pushed a commit to SaniyaKalamkar/numaflow that referenced this pull request Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants