fix: rollback codegen script #2079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Wang <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2079 +/- ##
==========================================
- Coverage 64.48% 64.30% -0.18%
==========================================
Files 322 322
Lines 30145 30145
==========================================
- Hits 19438 19386 -52
- Misses 9684 9739 +55
+ Partials 1023 1020 -3 ☔ View full report in Codecov by Sentry. |
vigith
approved these changes
Sep 23, 2024
whynowy
added a commit
that referenced
this pull request
Sep 26, 2024
Signed-off-by: Derek Wang <[email protected]>
SaniyaKalamkar
pushed a commit
to SaniyaKalamkar/numaflow
that referenced
this pull request
Jan 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
codegenstopped working after merging #2011, roll back the changes. @xdevxyThe new
code-generatorworks quite differently from current approach, which needs some effort to make it work for us. It also differs a lot even betweenv0.29andv0.30. We can stick with legacy approach for now, and fix it when the legacy approach is not supported any more.v0.29: https://github.com/kubernetes/code-generator/blob/v0.29.5/examples/hack/update-codegen.sh#L44-L57
v0.30: https://github.com/kubernetes/code-generator/blob/v0.30.5/examples/hack/update-codegen.sh#L40-L53