Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: example for PVC #2067

Merged
merged 2 commits into from
Sep 17, 2024
Merged

doc: example for PVC #2067

merged 2 commits into from
Sep 17, 2024

Conversation

vigith
Copy link
Member

@vigith vigith commented Sep 17, 2024

Explain what this PR does.

Signed-off-by: Vigith Maurice <[email protected]>
@vigith vigith requested a review from whynowy as a code owner September 17, 2024 17:04
@@ -47,3 +47,28 @@ spec:
- mountPath: /path/to/my-sink-config
name: my-udsink-config
```

### PVC Example
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.22%. Comparing base (692fbee) to head (68b6fd6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2067      +/-   ##
==========================================
- Coverage   63.37%   63.22%   -0.15%     
==========================================
  Files         319      319              
  Lines       29253    29253              
==========================================
- Hits        18538    18496      -42     
- Misses       9696     9732      +36     
- Partials     1019     1025       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Vigith Maurice <[email protected]>
@vigith vigith enabled auto-merge (squash) September 17, 2024 17:23
@vigith vigith merged commit cbe9054 into main Sep 17, 2024
25 checks passed
@vigith vigith deleted the doc-pvc branch September 17, 2024 17:37
whynowy pushed a commit that referenced this pull request Sep 26, 2024
Signed-off-by: Vigith Maurice <[email protected]>
SaniyaKalamkar pushed a commit to SaniyaKalamkar/numaflow that referenced this pull request Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants