Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove server info dependencies on go sdk #2060

Merged
merged 8 commits into from
Sep 14, 2024

Conversation

KeranYang
Copy link
Member

@KeranYang KeranYang commented Sep 13, 2024

closes #2034
closes #2033

  • Remove all dependencies on "github.com/numaproj/numaflow/pkg/sdkclient/serverinfo"
  • Also enable rust compatibility check

.
Signed-off-by: Keran Yang <[email protected]>
Copy link

codecov bot commented Sep 13, 2024

Codecov Report

Attention: Patch coverage is 59.79381% with 39 lines in your changes missing coverage. Please review.

Project coverage is 63.53%. Comparing base (49b733e) to head (64bf7ae).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/sdkclient/serverinfo/serverinfo.go 74.41% 7 Missing and 4 partials ⚠️
pkg/udf/map_udf.go 0.00% 4 Missing ⚠️
pkg/udf/reduce_udf.go 0.00% 4 Missing ⚠️
rust/monovertex/src/lib.rs 0.00% 4 Missing ⚠️
pkg/sdkclient/grpc/grpc_utils.go 0.00% 2 Missing ⚠️
pkg/sinks/sink.go 0.00% 2 Missing ⚠️
pkg/sources/source.go 0.00% 2 Missing ⚠️
pkg/sdkclient/batchmapper/client.go 0.00% 1 Missing ⚠️
pkg/sdkclient/mapper/client.go 0.00% 1 Missing ⚠️
pkg/sdkclient/mapstreamer/client.go 0.00% 1 Missing ⚠️
... and 7 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2060      +/-   ##
==========================================
+ Coverage   63.11%   63.53%   +0.41%     
==========================================
  Files         319      319              
  Lines       29180    29268      +88     
==========================================
+ Hits        18416    18594     +178     
+ Misses       9750     9651      -99     
- Partials     1014     1023       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Keran Yang <[email protected]>
@KeranYang KeranYang marked this pull request as ready for review September 13, 2024 14:44
@KeranYang KeranYang marked this pull request as draft September 13, 2024 14:52
.
Signed-off-by: Keran Yang <[email protected]>
.
Signed-off-by: Keran Yang <[email protected]>
.
Signed-off-by: Keran Yang <[email protected]>
@KeranYang KeranYang marked this pull request as ready for review September 13, 2024 18:22
@KeranYang KeranYang merged commit f00685a into numaproj:main Sep 14, 2024
25 checks passed
whynowy pushed a commit that referenced this pull request Sep 26, 2024
SaniyaKalamkar pushed a commit to SaniyaKalamkar/numaflow that referenced this pull request Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove unnecessary server-info dependency from numaflow-go enable versioning check for rust in numaflow
2 participants