chore: patch instead of update and bugfix #2059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Wang <[email protected]>
whynowy
commented
Sep 13, 2024
| @@ -236,6 +236,8 @@ func (mr *monoVertexReconciler) orchestratePods(ctx context.Context, monoVtx *df | |||
| monoVtx.Status.CurrentHash = monoVtx.Status.UpdateHash | |||
| } else { // Update scenario | |||
| if updatedReplicas >= desiredReplicas { | |||
| monoVtx.Status.UpdatedReplicas = uint32(desiredReplicas) | |||
| @@ -259,6 +259,8 @@ func (r *vertexReconciler) orchestratePods(ctx context.Context, vertex *dfv1.Ver | |||
| vertex.Status.CurrentHash = vertex.Status.UpdateHash | |||
| } else { // Update scenario | |||
| if updatedReplicas >= desiredReplicas { | |||
| vertex.Status.UpdatedReplicas = uint32(desiredReplicas) | |||
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2059 +/- ##
==========================================
+ Coverage 63.11% 63.38% +0.26%
==========================================
Files 319 319
Lines 29180 29253 +73
==========================================
+ Hits 18416 18541 +125
+ Misses 9750 9695 -55
- Partials 1014 1017 +3 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Derek Wang <[email protected]>
whynowy
commented
Sep 13, 2024
| @@ -292,7 +295,9 @@ func (r *pipelineReconciler) reconcileFixedResources(ctx context.Context, pl *df | |||
| r.recorder.Eventf(pl, corev1.EventTypeNormal, "CreateVertexSuccess", "Created vertex %s successfully", vertexName) | |||
| } else { | |||
| if oldObj.GetAnnotations()[dfv1.KeyHash] != newObj.GetAnnotations()[dfv1.KeyHash] { // need to update | |||
| originalReplicas := oldObj.Spec.Replicas | |||
vigith
approved these changes
Sep 14, 2024
pkg/reconciler/isbsvc/controller.go
Outdated
| if old == nil { | ||
| return true | ||
| func needsToPatchFinalizers(old, new *dfv1.InterStepBufferService) bool { | ||
| if old == nil { // This is a weird scenario, nothing we can do. Theoretically it will never happen. |
There was a problem hiding this comment.
since it is a weird scenario should be log so it might help whoever is debugging?
There was a problem hiding this comment.
Cleaned it up since there's no need to add this function.
| @@ -51,6 +51,8 @@ import ( | |||
|
|
|||
| const ( | |||
| finalizerName = dfv1.ControllerPipeline | |||
|
|
|||
| pauseTimestampPath = `/metadata/annotations/numaflow.numaproj.io~1pause-timestamp` | |||
There was a problem hiding this comment.
Signed-off-by: Derek Wang <[email protected]>
whynowy
added a commit
that referenced
this pull request
Sep 26, 2024
Signed-off-by: Derek Wang <[email protected]>
SaniyaKalamkar
pushed a commit
to SaniyaKalamkar/numaflow
that referenced
this pull request
Jan 19, 2025
Signed-off-by: Derek Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #2054
cpu: 2000mis updated tocpu: 2)min.updateHash != currentHash, it then it gets stuck.