Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: builtin transformer should keep the keys #2047

Merged
merged 5 commits into from
Sep 9, 2024

Conversation

KeranYang
Copy link
Member

@KeranYang KeranYang commented Sep 9, 2024

fixes #2043

Copy link

codecov bot commented Sep 9, 2024

Codecov Report

Attention: Patch coverage is 93.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 63.23%. Comparing base (24c6553) to head (387bf99).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...n/time_extraction_filter/time_extraction_filter.go 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2047      +/-   ##
==========================================
- Coverage   63.38%   63.23%   -0.16%     
==========================================
  Files         319      319              
  Lines       29171    29171              
==========================================
- Hits        18491    18445      -46     
- Misses       9665     9717      +52     
+ Partials     1015     1009       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KeranYang KeranYang marked this pull request as ready for review September 9, 2024 20:19
@KeranYang KeranYang merged commit ba40b15 into numaproj:main Sep 9, 2024
25 checks passed
whynowy pushed a commit that referenced this pull request Sep 26, 2024
SaniyaKalamkar pushed a commit to SaniyaKalamkar/numaflow that referenced this pull request Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

eventTimeExtractor to support keys
2 participants