-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: rolling update for Pipeline Vertex #2040
Conversation
Signed-off-by: Derek Wang <[email protected]>
Signed-off-by: Derek Wang <[email protected]>
Signed-off-by: Derek Wang <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2040 +/- ##
==========================================
+ Coverage 62.50% 63.25% +0.74%
==========================================
Files 319 319
Lines 29088 29171 +83
==========================================
+ Hits 18182 18451 +269
+ Misses 9921 9710 -211
- Partials 985 1010 +25 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Derek Wang <[email protected]>
Signed-off-by: Derek Wang <[email protected]>
Signed-off-by: Derek Wang <[email protected]>
Signed-off-by: Derek Wang <[email protected]>
@@ -715,29 +721,32 @@ type VertexStatus struct { | |||
// Total number of non-terminated pods targeted by this Vertex (their labels match the selector). | |||
// +optional | |||
Replicas uint32 `json:"replicas" protobuf:"varint,3,opt,name=replicas"` | |||
// The number of desired replicas. | |||
// +optional | |||
DesiredReplicas uint32 `json:"desiredReplicas" protobuf:"varint,4,opt,name=desiredReplicas"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how is this used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Displayed in kubectl get vtx
.
Signed-off-by: Derek Wang <[email protected]>
Hey. When reading Relase notes I have to dig deep to understand new features: For example rolling updates -> https://numaflow.numaproj.io/user-guide/reference/configuration/update-strategy/#update-strategy |
Signed-off-by: Derek Wang <[email protected]>
RollingUpdate
forPipeline
.