Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rolling update for Pipeline Vertex #2040

Merged
merged 7 commits into from
Sep 9, 2024
Merged

Conversation

whynowy
Copy link
Member

@whynowy whynowy commented Sep 8, 2024

RollingUpdate for Pipeline.

apiVersion: numaflow.numaproj.io/v1alpha1
kind: Pipeline
metadata:
  name: simple-pipeline
spec:
  vertices:
    - name: my-vertex
      updateStrategy:
        rollingUpdate:
          maxUnavailable: 25%
        type: RollingUpdate

Signed-off-by: Derek Wang <[email protected]>
Signed-off-by: Derek Wang <[email protected]>
Copy link

codecov bot commented Sep 8, 2024

Codecov Report

Attention: Patch coverage is 51.41700% with 120 lines in your changes missing coverage. Please review.

Project coverage is 63.25%. Comparing base (2189ea9) to head (a0d24a7).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/reconciler/vertex/controller.go 52.52% 65 Missing and 29 partials ⚠️
pkg/reconciler/monovertex/controller.go 0.00% 19 Missing ⚠️
pkg/reconciler/pipeline/controller.go 65.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2040      +/-   ##
==========================================
+ Coverage   62.50%   63.25%   +0.74%     
==========================================
  Files         319      319              
  Lines       29088    29171      +83     
==========================================
+ Hits        18182    18451     +269     
+ Misses       9921     9710     -211     
- Partials      985     1010      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Derek Wang <[email protected]>
Signed-off-by: Derek Wang <[email protected]>
@whynowy whynowy marked this pull request as ready for review September 9, 2024 03:53
@whynowy whynowy requested a review from vigith as a code owner September 9, 2024 03:53
Signed-off-by: Derek Wang <[email protected]>
Signed-off-by: Derek Wang <[email protected]>
@@ -715,29 +721,32 @@ type VertexStatus struct {
// Total number of non-terminated pods targeted by this Vertex (their labels match the selector).
// +optional
Replicas uint32 `json:"replicas" protobuf:"varint,3,opt,name=replicas"`
// The number of desired replicas.
// +optional
DesiredReplicas uint32 `json:"desiredReplicas" protobuf:"varint,4,opt,name=desiredReplicas"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how is this used?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Displayed in kubectl get vtx.

@whynowy whynowy merged commit c4b4d00 into numaproj:main Sep 9, 2024
25 checks passed
@whynowy whynowy deleted the veru branch September 9, 2024 17:09
whynowy added a commit that referenced this pull request Sep 26, 2024
@th0ger
Copy link
Contributor

th0ger commented Oct 14, 2024

Hey. When reading Relase notes I have to dig deep to understand new features:
Changelog -> PR -> Linked issue -> Changed files -> Updated Markdown -> Open the updated webdocs.
Would be so nice if you could link to the updated web docs directly in the release notes :-)

For example rolling updates -> https://numaflow.numaproj.io/user-guide/reference/configuration/update-strategy/#update-strategy

SaniyaKalamkar pushed a commit to SaniyaKalamkar/numaflow that referenced this pull request Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants