chore: minor pipeline controller refactor #2039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Wang <[email protected]>
Signed-off-by: Derek Wang <[email protected]>
Signed-off-by: Derek Wang <[email protected]>
whynowy
commented
Sep 7, 2024
| // +kubebuilder:default=false | ||
| // Field to indicate if a pipeline drain successfully occurred, only meaningful when the pipeline is paused. | ||
| // True means it has been successfully drained. | ||
| // +optional |
There was a problem hiding this comment.
We don't need to always display this in the status.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2039 +/- ##
==========================================
- Coverage 62.37% 62.33% -0.05%
==========================================
Files 319 319
Lines 29088 29088
==========================================
- Hits 18145 18132 -13
- Misses 9952 9965 +13
Partials 991 991 ☔ View full report in Codecov by Sentry. |
vigith
approved these changes
Sep 7, 2024
whynowy
added a commit
that referenced
this pull request
Sep 26, 2024
Signed-off-by: Derek Wang <[email protected]>
SaniyaKalamkar
pushed a commit
to SaniyaKalamkar/numaflow
that referenced
this pull request
Jan 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain what this PR does.