Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: switch to scratch base image #1955

Merged
merged 3 commits into from
Aug 17, 2024

Conversation

BulkBeing
Copy link
Contributor

@BulkBeing BulkBeing commented Aug 17, 2024

Explain what this PR does.
closes #1924

  • Builds Rust static binaries
  • Uses scratch as base for final image

@whynowy whynowy changed the title Use distroless image for numaflow chore: switch to scratch base image Aug 17, 2024
@BulkBeing BulkBeing marked this pull request as ready for review August 17, 2024 17:24
Copy link
Member

@whynowy whynowy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Aug 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.65%. Comparing base (0489eae) to head (382947a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1955      +/-   ##
==========================================
- Coverage   57.82%   57.65%   -0.17%     
==========================================
  Files         412      412              
  Lines       28789    28789              
==========================================
- Hits        16646    16598      -48     
- Misses      11203    11243      +40     
- Partials      940      948       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vigith vigith merged commit a52102d into numaproj:main Aug 17, 2024
26 checks passed
@BulkBeing BulkBeing deleted the rust-static-binaries branch August 19, 2024 01:09
KeranYang pushed a commit that referenced this pull request Aug 19, 2024
SaniyaKalamkar pushed a commit to SaniyaKalamkar/numaflow that referenced this pull request Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

move to scratch image from distroless
3 participants