Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: reorganize rust code #1922

Merged
merged 10 commits into from
Aug 12, 2024
Merged

chore: reorganize rust code #1922

merged 10 commits into from
Aug 12, 2024

Conversation

yhl25
Copy link
Contributor

@yhl25 yhl25 commented Aug 12, 2024

No description provided.

vigith and others added 8 commits August 11, 2024 21:27
@vigith
chore: reorg
2bcc7fb 
Signed-off-by: Vigith Maurice <[email protected]>
@yhl25
fix workspaces
1b18c12 
Signed-off-by: Yashash H L <[email protected]>
@yhl25
fix main docker file
dc87f70 
Signed-off-by: Yashash H L <[email protected]>
@yhl25
Merge branch 'main' of github.com:numaproj/numaflow into reorganize-r…
d90076a 
…ust-code
@yhl25
pass appropriate args
72872fe 
Signed-off-by: Yashash H L <[email protected]>
@yhl25
update makefile
4a97632 
Signed-off-by: Yashash H L <[email protected]>
@yhl25
better caching of dependencies
117bc6a 
Signed-off-by: Yashash H L <[email protected]>
@yhl25
use monovertex
5a4a01c 
Signed-off-by: Yashash H L <[email protected]>
@yhl25 yhl25 marked this pull request as ready for review August 12, 2024 15:33
@yhl25 yhl25 requested review from whynowy and vigith as code owners August 12, 2024 15:33
yhl25 added 2 commits August 12, 2024 21:22
@yhl25
fix ci
da714fd 
Signed-off-by: Yashash H L <[email protected]>
@yhl25
fix ci
a622377 
Signed-off-by: Yashash H L <[email protected]>
@codecov Codecov
Copy link

codecov bot commented Aug 12, 2024

Codecov Report

Attention: Patch coverage is 25.47170% with 79 lines in your changes missing coverage. Please review.

Project coverage is 57.88%. Comparing base (2fce26a) to head (a622377).

Files Patch % Lines
rust/monovertex/src/lib.rs 0.00% 59 Missing ⚠️
rust/src/bin/main.rs 0.00% 16 Missing ⚠️
rust/serving/src/lib.rs 0.00% 2 Missing ⚠️
pkg/apis/numaflow/v1alpha1/mono_vertex_types.go 0.00% 1 Missing ⚠️
rust/servesink/src/lib.rs 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1922      +/-   ##
==========================================
- Coverage   58.32%   57.88%   -0.45%     
==========================================
  Files         293      401     +108     
  Lines       24351    27769    +3418     
==========================================
+ Hits        14202    16073    +1871     
- Misses       9207    10761    +1554     
+ Partials      942      935       -7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vigith vigith enabled auto-merge (squash) August 12, 2024 16:38
@vigith vigith merged commit 91f9e8a into main Aug 12, 2024
24 of 25 checks passed
@vigith vigith deleted the reorganize-rust-code branch August 12, 2024 16:42
SaniyaKalamkar pushed a commit to SaniyaKalamkar/numaflow that referenced this pull request Aug 14, 2024
@yhl25 @vigith
chore: reorganize rust code (numaproj#1922)
adcad2a 
Signed-off-by: Vigith Maurice <[email protected]>
Signed-off-by: Yashash H L <[email protected]>
Co-authored-by: Vigith Maurice <[email protected]>
KeranYang pushed a commit that referenced this pull request Aug 19, 2024
@yhl25 @vigith @KeranYang
chore: reorganize rust code (#1922)
3d3b234 
Signed-off-by: Vigith Maurice <[email protected]>
Signed-off-by: Yashash H L <[email protected]>
Co-authored-by: Vigith Maurice <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vigith vigith vigith approved these changes

@whynowy whynowy Awaiting requested review from whynowy whynowy is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yhl25 @vigith