Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introducing MonoVertex #1911

Merged
merged 9 commits into from
Aug 8, 2024
Merged

feat: introducing MonoVertex #1911

merged 9 commits into from
Aug 8, 2024

Conversation

whynowy
Copy link
Member

@whynowy whynowy commented Aug 8, 2024

Explain what this PR does.

whynowy added 2 commits August 6, 2024 13:53
Signed-off-by: Derek Wang <[email protected]>
@whynowy whynowy requested a review from vigith as a code owner August 8, 2024 08:00
.
Signed-off-by: Derek Wang <[email protected]>
Copy link

codecov bot commented Aug 8, 2024

Codecov Report

Attention: Patch coverage is 7.15250% with 688 lines in your changes missing coverage. Please review.

Project coverage is 58.48%. Comparing base (9cf7624) to head (d2c38ea).

Files Patch % Lines
pkg/apis/numaflow/v1alpha1/mono_vertex_types.go 0.00% 280 Missing ⚠️
pkg/reconciler/monovertex/controller.go 0.00% 277 Missing ⚠️
pkg/mvtxdaemon/server/daemon_server.go 0.00% 80 Missing ⚠️
pkg/reconciler/cmd/start.go 0.00% 25 Missing ⚠️
cmd/commands/mvtx_daemon_server.go 20.00% 19 Missing and 1 partial ⚠️
pkg/apis/numaflow/v1alpha1/scale.go 90.47% 2 Missing and 2 partials ⚠️
pkg/reconciler/util.go 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1911      +/-   ##
==========================================
- Coverage   59.82%   58.48%   -1.34%     
==========================================
  Files         286      291       +5     
  Lines       23689    24381     +692     
==========================================
+ Hits        14172    14260      +88     
- Misses       8588     9187     +599     
- Partials      929      934       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

whynowy added 6 commits August 8, 2024 01:17
.
Signed-off-by: Derek Wang <[email protected]>
Signed-off-by: Derek Wang <[email protected]>
.
Signed-off-by: Derek Wang <[email protected]>
.
Signed-off-by: Derek Wang <[email protected]>
.
Signed-off-by: Derek Wang <[email protected]>
.
Signed-off-by: Derek Wang <[email protected]>
@vigith vigith linked an issue Aug 8, 2024 that may be closed by this pull request
@whynowy whynowy merged commit 51cc125 into numaproj:main Aug 8, 2024
25 checks passed
@whynowy whynowy deleted the neww branch August 8, 2024 21:02
SaniyaKalamkar pushed a commit to SaniyaKalamkar/numaflow that referenced this pull request Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MonoVertex CRD
2 participants