fix: access path for auth endpoints #1403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: veds-g <[email protected]>
vigith
reviewed
Dec 4, 2023
whynowy
reviewed
Dec 4, 2023
Signed-off-by: veds-g <[email protected]>
Signed-off-by: veds-g <[email protected]>
whynowy
reviewed
Dec 6, 2023
Signed-off-by: veds-g <[email protected]>
Signed-off-by: veds-g <[email protected]>
whynowy
approved these changes
Dec 6, 2023
server/authz/route_map.go
Outdated
| // It is called only once when the server starts. | ||
| // It adds baseHref to the routeMap keys. | ||
| // For example, "GET:/api/v1/namespaces" becomes "GET:/baseHref/api/v1/namespaces". | ||
| func InitializeRouteMapInfo(baseHref string) { |
There was a problem hiding this comment.
Let's see if there's a better pattern in the future.
vigith
reviewed
Dec 6, 2023
server/authz/route_map.go
Outdated
| "GET:/api/v1/metrics/namespaces/:namespace/pods": newRouteInfo(ObjectPipeline, true), | ||
| "GET:/api/v1/namespaces/:namespace/pods/:pod/logs": newRouteInfo(ObjectPipeline, true), | ||
| "GET:/api/v1/namespaces/:namespace/events": newRouteInfo(ObjectEvents, true), | ||
| var AuthRouteMap routeMap |
There was a problem hiding this comment.
global vars that are mutable could lead to race/concurrency issues.
There was a problem hiding this comment.
right, today we only update it once in the beginning, later we only perform read operations. Do you think this works as is now or should we refactor it?
There was a problem hiding this comment.
@veds-g - let's make routeMap an argument to the Routes() function, and pass to the casbin object.
Signed-off-by: veds-g <[email protected]>
vigith
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
auth/v1api endpoints