feat: Session Window and Reduce Streaming #1384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yashash H L <[email protected]>
Signed-off-by: Yashash H L <[email protected]>
Signed-off-by: Yashash H L <[email protected]>
Signed-off-by: Yashash H L <[email protected]>
Signed-off-by: Yashash H L <[email protected]>
Signed-off-by: Yashash H L <[email protected]>
Signed-off-by: Yashash H L <[email protected]>
Signed-off-by: Yashash H L <[email protected]>
Signed-off-by: Yashash H L <[email protected]>
Signed-off-by: Yashash H L <[email protected]>
Signed-off-by: Yashash H L <[email protected]>
Signed-off-by: Yashash H L <[email protected]>
Signed-off-by: Yashash H L <[email protected]>
Signed-off-by: Yashash H L <[email protected]>
Signed-off-by: Yashash H L <[email protected]>
Signed-off-by: Yashash H L <[email protected]>
Signed-off-by: Yashash H L <[email protected]>
Signed-off-by: Yashash H L <[email protected]>
Signed-off-by: Yashash H L <[email protected]>
Signed-off-by: Yashash H L <[email protected]>
Signed-off-by: Yashash H L <[email protected]>
Signed-off-by: Vigith Maurice <[email protected]>
Signed-off-by: Yashash H L <[email protected]>
Signed-off-by: Vigith Maurice <[email protected]>
Signed-off-by: Yashash H L <[email protected]>
Signed-off-by: Yashash H L <[email protected]>
Signed-off-by: Yashash H L <[email protected]>
Signed-off-by: Yashash H L <[email protected]>
Signed-off-by: Yashash H L <[email protected]>
Signed-off-by: Yashash H L <[email protected]>
Signed-off-by: Yashash H L <[email protected]>
Signed-off-by: Yashash H L <[email protected]>
Signed-off-by: Yashash H L <[email protected]>
Signed-off-by: Yashash H L <[email protected]>
Signed-off-by: Yashash H L <[email protected]>
whynowy
reviewed
Dec 11, 2023
pkg/apis/numaflow/v1alpha1/udf.go
Outdated
| } | ||
|
|
||
| // FixedWindow describes a fixed window | ||
| type FixedWindow struct { | ||
| Length *metav1.Duration `json:"length,omitempty" protobuf:"bytes,1,opt,name=length"` | ||
| // +optional | ||
| Streaming bool `json:"streaming,omitempty" protobuf:"bytes,3,opt,name=streaming"` |
| } | ||
|
|
||
| // SlidingWindow describes a sliding window | ||
| type SlidingWindow struct { | ||
| Length *metav1.Duration `json:"length,omitempty" protobuf:"bytes,1,opt,name=length"` | ||
| Slide *metav1.Duration `json:"slide,omitempty" protobuf:"bytes,2,opt,name=slide"` | ||
| // +optional |
KeranYang
reviewed
Dec 12, 2023
| return w.keys | ||
| } | ||
|
|
||
| func (w *sessionWindow) Partition() *partition.ID { |
There was a problem hiding this comment.
// Partition returns the partition id of the window
// which will be used to map to the pbq instance.
Partition() *partition.ID
Should we use SharedSessionPartition here for the session window? Since it's used for identifying the PBQ.
There was a problem hiding this comment.
both are a little different, I will update and fix the comments to avoid confusion.
Signed-off-by: Yashash H L <[email protected]>
Signed-off-by: Yashash H L <[email protected]>
Signed-off-by: Yashash H L <[email protected]>
Signed-off-by: Yashash H L <[email protected]>
vigith
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Controller changes to support session reduce, introduced a new object under groupBy called
"session", which takes a"timeout"field.Supporting streaming reduce, by making the
ReduceApplierasynchronous and theApplyReducefunction now returns a channel of responses and errors, enabling immediate forwarding results to ISB upon receiving SDK responses.Windowerinterfaces have been updated to support session reduce and streaming reduce, IntroducedTimedWindower,TimedWindow,TimedWindowRequestandTimedWindowResponsefor easier window operations such as create, delete, expand, merge and close, along with aSortedWindowByEndTimedata structure for better window tracking in windower.PBQsignatures have been updated to acceptTimedWindowRequests, in line withReduceAppliernow takingTimedWindowRequestsand returningTimedWindowResponses.PnF has been updated to support async and session reduce, and it takes care of publishing monotonically increasing watermarks.
Tracking of closed windows previously in the
PBQManagerhas been moved to the windower, suiting multiple windows in a session sharing a common PBQ. Now,DataForwardandPnFwill use the windower for all window-related operations.